From: Scott Wood <scottwood@freescale•com>
To: Kevin Hao <haokexin@gmail•com>
Cc: linuxppc <linuxppc-dev@lists•ozlabs.org>
Subject: Re: [PATCH 1/3] powerpc/mpc85xx: remove the unneeded pci init functions for corenet ds board
Date: Mon, 3 Jun 2013 11:42:03 -0500 [thread overview]
Message-ID: <1370277723.21388.1@snotra> (raw)
In-Reply-To: <20130602000720.GA22546@pek-khao-d1.corp.ad.wrs.com> (from haokexin@gmail.com on Sat Jun 1 19:07:20 2013)
On 06/01/2013 07:07:20 PM, Kevin Hao wrote:
> On Sat, Jun 01, 2013 at 09:47:16PM +1000, Benjamin Herrenschmidt =20
> wrote:
> > On Sat, 2013-06-01 at 18:59 +0800, Kevin Hao wrote:
> >
> > > The effect of this change is that the isa_io_base will be 0 and =20
> the IO
> > > resource are equal to the virtual address of the IO space. But =20
> the IO
> > > functions such as outx/inx should work as well. This is why I ask =20
> the
> > > above question. What do you think about this? Are there any =20
> subtle bugs
> > > that will be triggered by this?
> >
> > I don't see any obvious reason why that wouldn't work but like =20
> anything
> > in that area, it needs a bit of testing & hammering to be sure ;-)
>=20
> Agreed.
Please include QEMU in your testing, as that was where breakage was =20
observed that caused us to add the default primary.
> > In fact it would work on pmac32 as well since those generally don't =20
> have
> > legacy crap either.
> >
> > So I have no fundamental objection, it just needs testing. My worry =20
> is
> > that we need to make sure we don't break old chrp and I don't have =20
> any
> > to test with.
>=20
> Don't worry, my patch just drop the picking of primary bus for several
> fsl boards. All these changes are in board specific file, so it should
> have no affect to other boards at all.
Is anything actually fixed by this?
-Scott=
next prev parent reply other threads:[~2013-06-03 16:42 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-21 12:04 [PATCH 0/3] several cleanup patches for fsl pci Kevin Hao
2013-05-21 12:04 ` [PATCH 1/3] powerpc/mpc85xx: remove the unneeded pci init functions for corenet ds board Kevin Hao
2013-05-28 22:52 ` Scott Wood
2013-05-30 10:20 ` Kevin Hao
2013-05-30 18:54 ` Scott Wood
2013-05-31 6:41 ` Kevin Hao
2013-05-31 10:11 ` Benjamin Herrenschmidt
2013-06-01 10:59 ` Kevin Hao
2013-06-01 11:47 ` Benjamin Herrenschmidt
2013-06-02 0:07 ` Kevin Hao
2013-06-03 16:42 ` Scott Wood [this message]
2013-06-07 2:00 ` Kevin Hao
2013-06-08 0:00 ` Scott Wood
2013-07-23 22:31 ` Scott Wood
2013-07-25 12:54 ` Kevin Hao
2013-07-26 22:43 ` Scott Wood
2013-07-28 0:32 ` Kevin Hao
2013-05-31 6:43 ` Kevin Hao
2013-05-31 23:27 ` Scott Wood
2013-06-01 11:13 ` Kevin Hao
2013-05-21 12:04 ` [PATCH 2/3] powerpc/fsl-pci: fix the unreachable warning message Kevin Hao
2013-05-21 12:05 ` [PATCH 3/3] powerpc/fsl-pci: enable SWIOTLB in function setup_pci_atmu Kevin Hao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1370277723.21388.1@snotra \
--to=scottwood@freescale$(echo .)com \
--cc=haokexin@gmail$(echo .)com \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox