Subject: Re: [PATCH v2 05/15] fsl_pmc: update device bindings

From: Scott Wood <[email-masked]>
Date: Mon, 3 Jun 2013 17:43:05 -0500

On 04/19/2013 05:47:38 AM, Zhao Chenhui wrote:
> From: Li Yang <[email-masked]>
>=20
> Signed-off-by: Li Yang <[email-masked]>
> Signed-off-by: Zhao Chenhui <[email-masked]>
> ---
>  .../devicetree/bindings/powerpc/fsl/pmc.txt        |   59 =20
> +++++++++++--------
>  1 files changed, 34 insertions(+), 25 deletions(-)
>=20
> diff --git a/Documentation/devicetree/bindings/powerpc/fsl/pmc.txt =20
> b/Documentation/devicetree/bindings/powerpc/fsl/pmc.txt
> index 07256b7..f1f749f 100644
> --- a/Documentation/devicetree/bindings/powerpc/fsl/pmc.txt
> +++ b/Documentation/devicetree/bindings/powerpc/fsl/pmc.txt
> @@ -9,15 +9,20 @@ Properties:
>=20
>    "fsl,mpc8548-pmc" should be listed for any chip whose PMC is
>    compatible.  "fsl,mpc8536-pmc" should also be listed for any chip
> -  whose PMC is compatible, and implies deep-sleep capability.
> +  whose PMC is compatible, and implies deep-sleep capability and
> +  wake on user defined packet(wakeup on ARP).
> +
> +  "fsl,p1022-pmc" should be listed for any chip whose PMC is
> +  compatible, and implies lossless Ethernet capability during sleep.
>=20
>    "fsl,mpc8641d-pmc" should be listed for any chip whose PMC is
>    compatible; all statements below that apply to "fsl,mpc8548-pmc" =20
> also
>    apply to "fsl,mpc8641d-pmc".
>=20
>    Compatibility does not include bit assignments in =20
> SCCR/PMCDR/DEVDISR; these
> -  bit assignments are indicated via the sleep specifier in each =20
> device's
> -  sleep property.
> +  bit assignments are indicated via the clock nodes.  Device which =20
> has a
> +  controllable clock source should have a "fsl,pmc-handle" property =20
> pointing
> +  to the clock node.

Please respond to the feedback given on v1:
http://patchwork.ozlabs.org/patch/147177/

Also indicate, below the ---, what has changed from previous versions.

-Scott=