public inbox for linuxppc-dev@ozlabs.org 
 help / color / mirror / Atom feed
From: Scott Wood <scottwood@freescale•com>
To: Lijun Pan <Lijun.Pan@freescale•com>
Cc: linuxppc-dev@ozlabs•org, Lijun.Pan@freescale•com
Subject: Re: [PATCH 2/3] powerpc/perf: add 2 additional performance monitor counters for e6500 core
Date: Tue, 4 Jun 2013 13:10:43 -0500	[thread overview]
Message-ID: <1370369443.748.8@snotra> (raw)
In-Reply-To: <1369865562-29525-2-git-send-email-Lijun.Pan@freescale.com> (from Lijun.Pan@freescale.com on Wed May 29 17:12:41 2013)

On 05/29/2013 05:12:41 PM, Lijun Pan wrote:
> diff --git a/arch/powerpc/kernel/cputable.c =20
> b/arch/powerpc/kernel/cputable.c
> index cc39139..2d4eee2 100644
> --- a/arch/powerpc/kernel/cputable.c
> +++ b/arch/powerpc/kernel/cputable.c
> @@ -2073,7 +2073,7 @@ static struct cpu_spec __initdata cpu_specs[] =3D =20
> {
>  			MMU_FTR_USE_TLBILX,
>  		.icache_bsize		=3D 64,
>  		.dcache_bsize		=3D 64,
> -		.num_pmcs		=3D 4,
> +		.num_pmcs		=3D 6,
>  		.oprofile_cpu_type	=3D "ppc/e6500",
>  		.oprofile_type		=3D PPC_OPROFILE_FSL_EMB,
>  		.cpu_setup		=3D __setup_cpu_e6500,

This will overflow MAX_HWEVENTS.  Please include "powerpc perf: =20
increase the perf HW events to 6" from our SDK tree before this patch =20
(be sure to change "powerpc perf" to "powerpc/perf" and remove the =20
gerrit tags when you do so).

-Scott=

  reply	other threads:[~2013-06-04 18:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-29 22:12 [PATCH 1/3] powerpc/perf: correct typos in counter enumeration Lijun Pan
2013-05-29 22:12 ` [PATCH 2/3] powerpc/perf: add 2 additional performance monitor counters for e6500 core Lijun Pan
2013-06-04 18:10   ` Scott Wood [this message]
2013-06-05 16:57     ` Pan Lijun-B44306
2013-05-29 22:12 ` [PATCH 3/3] powerpc/perf: Add e6500 PMU driver Lijun Pan
  -- strict thread matches above, loose matches on Subject: below --
2013-05-02 18:08 [PATCH 1/3] powerpc/perf: correct typos in counter enumeration Lijun Pan
2013-05-02 18:08 ` [PATCH 2/3] powerpc/perf: add 2 additional performance monitor counters for e6500 core Lijun Pan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1370369443.748.8@snotra \
    --to=scottwood@freescale$(echo .)com \
    --cc=Lijun.Pan@freescale$(echo .)com \
    --cc=linuxppc-dev@ozlabs$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox