Subject: Re: [PATCH 1/6] powerpc/eeh: Don't collect PCI-CFG data on PHB

From: Benjamin Herrenschmidt <[email-masked]>
Date: Tue, 25 Jun 2013 21:56:06 +1000

On Tue, 2013-06-25 at 18:00 +0800, Gavin Shan wrote:
> +               pci_regs_buf[0] = 0;
> +               eeh_pe_for_each_dev(pe, edev) {
> +                       loglen += eeh_gather_pci_data(edev, pci_regs_buf,
> +                                                     EEH_PCI_REGS_LOG_LEN);
> +               }
> +       }

Unless I'm mistaken, this is buggy and will overwrite the content of
pci_regs_buf for every device (they will all write over the same
portion of the log).

Ben.