Subject: Re: [PATCH][v2] powerpc/85xx: Move ePAPR paravirt initialization earlier

From: Scott Wood <[email-masked]>
Date: Wed, 3 Jul 2013 09:52:46 -0500

On 07/03/2013 07:29:43 AM, Tudor Laurentiu wrote:
> On 07/02/2013 08:55 PM, Scott Wood wrote:
>> On 07/02/2013 07:46:29 AM, Laurentiu Tudor wrote:
>>> - insts =3D of_get_property(hyper_node, "hcall-instructions", &len);
>>> - if (!insts)
>>> - return -ENODEV;
>>> +#if !defined(CONFIG_64BIT) || defined(CONFIG_PPC_BOOK3E_64)
>>> + if (of_get_flat_dt_prop(node, "has-idle", NULL))
>>> + ppc_md.power_save =3D epapr_ev_idle;
>>> +#endif
>>=20
>> Why are you doing this before processing hcall-instructions?
>>=20
>=20
> Nothing of importance. The code seemed more clear to me.

It seems wrong to expose epapr_ev_idle to ppc_md before the hcall has =20
been patched in, even if you don't expect to actually go idle at this =20
point.

-Scott=