Subject: Re: [PATCH] Powerpc/t4240: change the compatible flags for t4240qds board

From: Scott Wood <[email-masked]>
Date: Mon, 8 Jul 2013 12:14:05 -0500

On 07/08/2013 02:16:03 AM, Haijun Zhang wrote:
> In order to make a difference between different T4240 board.
> Specify T4240QDS board the unique compatible flags for t4240qds
> eSDHC host.
>=20
> Signed-off-by: Haijun Zhang <[email-masked]>
> ---
>  arch/powerpc/boot/dts/fsl/t4240si-post.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/arch/powerpc/boot/dts/fsl/t4240si-post.dtsi =20
> b/arch/powerpc/boot/dts/fsl/t4240si-post.dtsi
> index bd611a9..08b47d0 100644
> --- a/arch/powerpc/boot/dts/fsl/t4240si-post.dtsi
> +++ b/arch/powerpc/boot/dts/fsl/t4240si-post.dtsi
> @@ -397,7 +397,7 @@
>=20
>  /include/ "qoriq-esdhc-0.dtsi"
>  	sdhc@114000 {
> -		compatible =3D "fsl,t4240-esdhc", "fsl,esdhc";
> +		compatible =3D "fsl,t4240qds-esdhc", "fsl,esdhc";
>  		sdhci,auto-cmd12;
>  	};

NACK.  This node is describing the sdhc block of the t4240 SoC.  What =20
board you stick it in doesn't change what it is.

Plus, what about users with old device trees?

-Scott=