Subject: Re: [PATCH 3/4 V2] mmc: esdhc: Add quirks to support T4240QDS board

From: Scott Wood <[email-masked]>
Date: Mon, 8 Jul 2013 12:18:39 -0500

On 07/08/2013 02:16:04 AM, Haijun Zhang wrote:
> On T4240QDS board controllers has an unusable ADMA engine, so use =20
> SDMA instead.
> Also 3.0v is support on T4240QDS board even if the capacity detailed =20
> only 1.8v
> support. Without this quirk SD card will declare voltage not support =20
> and
>=20
> Signed-off-by: Haijun Zhang <[email-masked]>

...and what?

Why is this board-specific?  Isn't the controller part of the SoC, not =20
part of the board?  If it really is board-specific, could you be more =20
detailed about why (ideally with an erratum number), and check the =20
toplevel board compatible (or get the information from platform code) =20
rather than modify the device tree?

-Scott=