Subject: Re: 答复: [PATCH] Powerpc/t4240: change the compatible flags for t4240qds board

From: Scott Wood <[email-masked]>
Date: Tue, 9 Jul 2013 15:04:22 -0500

On 07/09/2013 01:04:01 AM, Zhang Haijun-B42677 wrote:
> 
> 
> Regards & Thanks
> 
> Haijun.
> 
> ________________________________________
> 发件人: Wood Scott-B07421
> 发送时间: 2013年7月8日 17:14
> 收件人: Zhang Haijun-B42677
> 抄送: [email-masked]; [email-masked];  
> [email-masked]; [email-masked]; Fleming Andy-AFLEMING; Wrobel  
> Heinz-R39252; Zhang Haijun-B42677
> 主题: Re: [PATCH] Powerpc/t4240: change the compatible flags for  
> t4240qds board
> 
> On 07/08/2013 02:16:03 AM, Haijun Zhang wrote:
> > In order to make a difference between different T4240 board.
> > Specify T4240QDS board the unique compatible flags for t4240qds
> > eSDHC host.
> >
> > Signed-off-by: Haijun Zhang <[email-masked]>
> > ---
> >  arch/powerpc/boot/dts/fsl/t4240si-post.dtsi | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/powerpc/boot/dts/fsl/t4240si-post.dtsi
> > b/arch/powerpc/boot/dts/fsl/t4240si-post.dtsi
> > index bd611a9..08b47d0 100644
> > --- a/arch/powerpc/boot/dts/fsl/t4240si-post.dtsi
> > +++ b/arch/powerpc/boot/dts/fsl/t4240si-post.dtsi
> > @@ -397,7 +397,7 @@
> >
> >  /include/ "qoriq-esdhc-0.dtsi"
> >       sdhc@114000 {
> > -             compatible = "fsl,t4240-esdhc", "fsl,esdhc";
> > +             compatible = "fsl,t4240qds-esdhc", "fsl,esdhc";
> >               sdhci,auto-cmd12;
> >       };
> 
> NACK.  This node is describing the sdhc block of the t4240 SoC.  What
> board you stick it in doesn't change what it is.
> 
> Plus, what about users with old device trees?
> 
> Currently no users use this ip block except esdhc driver.

I'm not talking about code users.  I'm talking about people users.

> How about change this in arch/powerpc/boot/dts/t4240qds.dts
> 
> +++ b/arch/powerpc/boot/dts/t4240qds.dts
> @@ -117,6 +117,10 @@
>                         };
>                 };
> 
>                sdhc@114000 {
>                       compatible = "fsl,t4240-esdhc", "fsl,esdhc";
>                };
> 
>                i2c@118000 {
> 
> 
> +++ b/arch/powerpc/boot/dts/t4240qds.dts
> @@ -117,6 +117,10 @@
>                         };
>                 };
> 
> +               sdhc@114000 {
> +                       compatible = "fsl,t4240qds-esdhc",  
> "fsl,esdhc";
> +               };
> +
>                 i2c@118000 {

No.  It's still supposed to be describing the sdhc block itself, not  
the board -- and any workarounds that key off of this will still fail  
to work with existing device trees.

-Scott