Subject: Re: 答复: [PATCH] Powerpc/t4240: change the compatible flags for t4240qds board

From: Scott Wood <[email-masked]>
Date: Wed, 10 Jul 2013 15:30:05 -0500

On 07/09/2013 10:41:22 PM, Zhang Haijun-B42677 wrote:
> > No.  It's still supposed to be describing the sdhc block itself, =20
> not the
> > board -- and any workarounds that key off of this will still fail =20
> to work
> > with existing device trees.
> [Haijun Wrote:] So, leave dts unchanged and to check compitable for =20
> board in sdhci-pltfm.c
> e.g.:
> 	unsigned long root =3D of_get_flat_dt_root();
>=20
> 	if (of_flat_dt_is_compatible(root, "fsl,T4240QDS"))
> 		host->quirks |=3D XXX;

Why are you looking at the flat tree at this point?  Use the normal OF =20
accessors.  The flat stuff is only for early boot.

Also make sure that you only do this for quirks that are actually =20
board-specific.  In your last patch you had two quirks keyed off of the =20
board, one of which is keyed off of the SoC for other chips.

-SCott=