Subject: Re: [PATCH 1/4 V2] powerpc/85xx: Add support for 85xx cpu type detection

From: Scott Wood <[email-masked]>
Date: Wed, 10 Jul 2013 16:48:13 -0500

On 07/10/2013 02:39:01 AM, Haijun Zhang wrote:
> +/* Get current SOC Version */
> +#define GET_SVR()	(mfspr(SPRN_SVR))

Unnecessary parens.  Why do we need GET_SVR(), versus opencoding it?  =20
Note that U-Boot (which this is patterned after) doesn't have =20
GET_SVR(), so code that wants to work on both can't use it anyway.

> +#define IS_SVR_REV(svr, maj, min) \
> +	((SVR_MAJ(svr) =3D=3D (maj)) && (SVR_MIN(svr) =3D=3D (min)))

I don't think IS_SVR_REV is needed.  Callers can just do "if =20
(SVR_REV(svr) =3D=3D 0x30)" or whatever, especially since we're relying on =
=20
them to do this for greater/less than comparisons.

-Scott=