Subject: Re: [PATCH 2/2 V4] powerpc/85xx: add the P1020RDB-PD DTS support

From: Scott Wood <[email-masked]>
Date: Thu, 11 Jul 2013 15:34:18 -0500

On 07/09/2013 09:24:57 PM, Haijun Zhang wrote:
> +		nand@1,0 {
> +			#address-cells =3D <1>;
> +			#size-cells =3D <1>;
> +			compatible =3D "fsl,p1020-fcm-nand",
> +				     "fsl,elbc-fcm-nand";
> +			reg =3D <0x1 0x0 0x40000>;
> +
> +			partition@0 {
> +				/* This location must not be altered  */
> +				/* 1MB for u-boot Bootloader Image */
> +				reg =3D <0x0 0x00100000>;
> +				label =3D "NAND U-Boot Image";
> +				read-only;
> +			};
> +
> +			partition@100000 {
> +				/* 1MB for DTB Image */
> +				reg =3D <0x00100000 0x00100000>;
> +				label =3D "NAND DTB Image";
> +			};
> +
> +			partition@200000 {
> +				/* 4MB for Linux Kernel Image */
> +				reg =3D <0x00200000 0x00400000>;
> +				label =3D "NAND Linux Kernel Image";
> +			};
> +
> +			partition@600000 {
> +				/* 96MB for File System Image */
> +				reg =3D <0x00600000 0x06000000>;
> +				label =3D "NAND FILE System Image";
> +			};

This accounts for 102 MiB of the flash.  The rest is just unused?  Why =20
not increase the filesystem partition?

Also, why capitalize "FILE"?

> +		spi@7000 {
> +			flash@0 {
> +				#address-cells =3D <1>;
> +				#size-cells =3D <1>;
> +				compatible =3D "spansion,s25sl12801";
> +				reg =3D <0>;
> +				/* input clock */
> +				spi-max-frequency =3D <40000000>;
> +
> +				partition@0 {
> +					/* 512KB for u-boot Bootloader =20
> Image */
> +					reg =3D <0x0 0x00080000>;
> +					label =3D "SPI U-Boot Image";
> +					read-only;
> +				};
> +
> +				partition@80000 {
> +					/* 512KB for DTB Image*/
> +					reg =3D <0x00080000 0x00080000>;
> +					label =3D "SPI DTB Image";
> +				};
> +
> +				partition@100000 {
> +					/* 4MB for Linux Kernel Image */
> +					reg =3D <0x00100000 0x00400000>;
> +					label =3D "SPI Linux Kernel =20
> Image";
> +				};
> +
> +				partition@500000 {
> +					/* 7MB for FS System Image */
> +					reg =3D <0x00500000 0x00700000>;
> +					label =3D "SPI File System Image";
> +				};
> +			};

Likewise.

-Scott=