From: Scott Wood <scottwood@freescale•com>
To: Kevin Hao <haokexin@gmail•com>
Cc: linuxppc <linuxppc-dev@lists•ozlabs.org>
Subject: Re: [PATCH 2/2] powerpc/math-emu: keep track of the instructions unimplemented by FPU
Date: Fri, 12 Jul 2013 15:53:19 -0500 [thread overview]
Message-ID: <1373662399.8183.283@snotra> (raw)
In-Reply-To: <20130712022512.GB32154@pek-khao-d1.corp.ad.wrs.com> (from haokexin@gmail.com on Thu Jul 11 21:25:12 2013)
On 07/11/2013 09:25:12 PM, Kevin Hao wrote:
> On Thu, Jul 11, 2013 at 09:30:02AM -0500, Scott Wood wrote:
> > Sorry, that was my fault -- for some reason I didn't see that when I
> > grepped for PPC_WARN_EMULATED looking for math stuff, and thus
> > requested it be added. In any case, I don't see why it should be
> > conditional on having an FPU (and indeed, the warning in the caller
> > isn't conditional).
>=20
> I thought it only made sense to warn only for the case when the core
> does have a FPU but some unimplemented floating instructions are =20
> emulated.
> As for the core which doesn't have a FPU at all and we explicitly =20
> enable the
> math emulation it may seems a little redundant to warn in this case. =20
> But after
> a second thought, this is the statistics of all the emulated =20
> instructions,
> so it does seem reasonable to warn in all cases. I will remove the =20
> dependancy
> on FPU.
It's not redundant at all to warn when an FPU is absent. It tells you =20
that you're being slowed down by running hard-FP code instead of =20
soft-FP code.
-Scott=
next prev parent reply other threads:[~2013-07-12 20:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-11 12:21 [PATCH 0/2] powerpc/math-emu: two patches for the emulation of the FPU unimplemented instructions Kevin Hao
2013-07-11 12:21 ` [PATCH 1/2] powerpc/math-emu: move the flush FPU state function into do_mathemu Kevin Hao
2013-07-12 0:34 ` Matt Helsley
2013-07-14 8:11 ` Kevin Hao
2013-07-11 12:21 ` [PATCH 2/2] powerpc/math-emu: keep track of the instructions unimplemented by FPU Kevin Hao
2013-07-11 12:45 ` Benjamin Herrenschmidt
2013-07-11 14:30 ` Scott Wood
2013-07-12 2:25 ` Kevin Hao
2013-07-12 20:53 ` Scott Wood [this message]
2013-07-12 23:05 ` Benjamin Herrenschmidt
2013-07-12 2:07 ` Kevin Hao
2013-07-12 3:56 ` Benjamin Herrenschmidt
2013-07-12 5:05 ` Kevin Hao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1373662399.8183.283@snotra \
--to=scottwood@freescale$(echo .)com \
--cc=haokexin@gmail$(echo .)com \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox