Subject: Re: [PATCH v3 1/2] DMA: Freescale: Add new 8-channel DMA engine device tree nodes

From: Scott Wood <[email-masked]>
Date: Mon, 15 Jul 2013 12:57:05 -0500

On 07/15/2013 05:34:58 AM, [email-masked] wrote:
> From: Hongbo Zhang <[email-masked]>
>=20
> Freescale QorIQ T4 and B4 introduce new 8-channel DMA engines, this =20
> patch add
> the device tree nodes for them.
>=20
> Signed-off-by: Hongbo Zhang <[email-masked]>
> ---
>  .../devicetree/bindings/powerpc/fsl/dma.txt        |    8 +-
>  arch/powerpc/boot/dts/fsl/elo3-dma-0.dtsi          |   90 =20
> ++++++++++++++++++++
>  arch/powerpc/boot/dts/fsl/elo3-dma-1.dtsi          |   90 =20
> ++++++++++++++++++++
>  arch/powerpc/boot/dts/fsl/t4240si-post.dtsi        |    4 +-
>  4 files changed, 187 insertions(+), 5 deletions(-)
>  create mode 100644 arch/powerpc/boot/dts/fsl/elo3-dma-0.dtsi
>  create mode 100644 arch/powerpc/boot/dts/fsl/elo3-dma-1.dtsi
>=20
> diff --git a/Documentation/devicetree/bindings/powerpc/fsl/dma.txt =20
> b/Documentation/devicetree/bindings/powerpc/fsl/dma.txt
> index 2a4b4bc..8ee5732 100644
> --- a/Documentation/devicetree/bindings/powerpc/fsl/dma.txt
> +++ b/Documentation/devicetree/bindings/powerpc/fsl/dma.txt
> @@ -76,10 +76,10 @@ Freescale PowerPC 85xx/86xx have on chip general =20
> purpose DMA controllers.
>=20
>  Required properties:
>=20
> -- compatible        : compatible list, contains 2 entries, first is
> +- compatible        : compatible list, contains 3 entries, first is
>  		 "fsl,CHIP-dma", where CHIP is the processor
>  		 (mpc8540, mpc8540, etc.) and the second is
> -		 "fsl,eloplus-dma"
> +		 "fsl,eloplus-dma", the third is "fsl,elo3-dma"

The new device tree nodes have only one compatible in the list, not =20
three.  And if you were to both fsl,eloplus-dma and fsl,elo3-dma on the =20
same node, fsl,elo3-dma should come first.

>  - reg               : <registers mapping for DMA general status reg>
>  - cell-index        : controller index.  0 for controller @ 0x21000,
>                                           1 for controller @ 0xc000
> @@ -100,7 +100,7 @@ Example:
>  	dma@21300 {
>  		#address-cells =3D <1>;
>  		#size-cells =3D <1>;
> -		compatible =3D "fsl,mpc8540-dma", "fsl,eloplus-dma";
> +		compatible =3D "fsl,mpc8540-dma", "fsl,eloplus-dma", =20
> "fsl,elo3-dma";

In addition to the above issue about ordering, mpc8540 does not have =20
elo3.

-Scott=