Subject: Re: [PATCH 1/3] mmc:core: parse voltage from device-tree

From: Scott Wood <[email-masked]>
Date: Tue, 30 Jul 2013 14:58:54 -0500

On 07/29/2013 08:34:29 PM, Zhang Haijun wrote:
> On 07/30/2013 06:07 AM, Scott Wood wrote:
>> On 07/28/2013 09:56:33 PM, Haijun Zhang wrote:
>>> Add function to support get voltage from device-tree.
>>> If there are voltage-range specified in device-tree node, this =20
>>> function
>>> will parse it and return the avail voltage mask.
>>>=20
>>> Signed-off-by: Haijun Zhang <[email-masked]>
>>> ---
>>>  drivers/mmc/core/core.c  | 48 =20
>>> ++++++++++++++++++++++++++++++++++++++++++++++++
>>>  include/linux/mmc/core.h |  1 +
>>>  2 files changed, 49 insertions(+)
>>=20
>> Move the code rather than copying it.
>>=20
>> -Scott
> Hi, Scott
>=20
> You mean?

The point of factoring this out is to avoid duplicating the code.  If =20
you don't remove it from the place you copied it from (and have that =20
code call here instead), then you're not avoiding the duplication.

-Scott=