From: Toshi Kani <toshi.kani@hp•com>
To: "Rafael J. Wysocki" <rjw@sisk•pl>
Cc: "fenghua.yu@intel•com" <fenghua.yu@intel•com>,
"bp@suse•de" <bp@suse•de>,
"gregkh@linuxfoundation•org" <gregkh@linuxfoundation•org>,
"x86@kernel•org" <x86@kernel•org>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>,
"linux-acpi@vger•kernel.org" <linux-acpi@vger•kernel.org>,
"isimatu.yasuaki@jp•fujitsu.com" <isimatu.yasuaki@jp•fujitsu.com>,
"mingo@redhat•com" <mingo@redhat•com>,
"srivatsa.bhat@linux•vnet.ibm.com"
<srivatsa.bhat@linux•vnet.ibm.com>,
"nfont@linux•vnet.ibm.com" <nfont@linux•vnet.ibm.com>,
"tglx@linutronix•de" <tglx@linutronix•de>,
"hpa@linux•intel.com" <hpa@linux•intel.com>,
"linuxppc-dev@lists•ozlabs.org" <linuxppc-dev@lists•ozlabs.org>
Subject: Re: [PATCH v2 4/4] hotplug, powerpc, x86: Remove cpu_hotplug_driver_lock()
Date: Wed, 25 Sep 2013 14:44:59 -0600 [thread overview]
Message-ID: <1380141899.14046.18.camel@misato.fc.hp.com> (raw)
In-Reply-To: <7232059.d6LGFPRAoP@vostro.rjw.lan>
On Wed, 2013-09-25 at 08:27 +0000, Rafael J. Wysocki wrote:
> Hi,
>
> On Thursday, August 29, 2013 06:22:09 PM Toshi Kani wrote:
> > cpu_hotplug_driver_lock() serializes CPU online/offline operations
> > when ARCH_CPU_PROBE_RELEASE is set. This lock interface is no longer
> > necessary with the following reason:
> >
> > - lock_device_hotplug() now protects CPU online/offline operations,
> > including the probe & release interfaces enabled by
> > ARCH_CPU_PROBE_RELEASE. The use of cpu_hotplug_driver_lock() is
> > redundant.
> > - cpu_hotplug_driver_lock() is only valid when ARCH_CPU_PROBE_RELEASE
> > is defined, which is misleading and is only enabled on powerpc.
> >
> > This patch removes the cpu_hotplug_driver_lock() interface. As
> > a result, ARCH_CPU_PROBE_RELEASE only enables / disables the cpu
> > probe & release interface as intended. There is no functional change
> > in this patch.
> >
> > Signed-off-by: Toshi Kani <toshi.kani@hp•com>
> > Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel•com>
> > Reviewed-by: Nathan Fontenot <nfont@linux•vnet.ibm.com>
>
> Can you please rebase this patch on top of 3.12-rc2? It doesn't apply for
> me any more.
Yes, I will send this patch on top of 3.12-rc2.
Thanks,
-Toshi
next prev parent reply other threads:[~2013-09-25 20:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-30 0:22 [PATCH v2 0/4] Unify CPU hotplug lock interface Toshi Kani
2013-08-30 0:22 ` [PATCH v2 1/4] hotplug, x86: Fix online state in cpu0 debug interface Toshi Kani
2013-08-31 0:24 ` Rafael J. Wysocki
2013-08-30 0:22 ` [PATCH v2 2/4] hotplug, x86: Add hotplug lock to missing places Toshi Kani
2013-08-30 0:22 ` [PATCH v2 3/4] hotplug, x86: Disable ARCH_CPU_PROBE_RELEASE on x86 Toshi Kani
2013-08-30 0:22 ` [PATCH v2 4/4] hotplug, powerpc, x86: Remove cpu_hotplug_driver_lock() Toshi Kani
2013-09-25 8:27 ` Rafael J. Wysocki
2013-09-25 20:44 ` Toshi Kani [this message]
2013-08-30 2:44 ` [PATCH v2 0/4] Unify CPU hotplug lock interface Yasuaki Ishimatsu
2013-08-30 12:14 ` Rafael J. Wysocki
2013-08-30 14:35 ` Toshi Kani
2013-08-30 14:33 ` Toshi Kani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1380141899.14046.18.camel@misato.fc.hp.com \
--to=toshi.kani@hp$(echo .)com \
--cc=bp@suse$(echo .)de \
--cc=fenghua.yu@intel$(echo .)com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=hpa@linux$(echo .)intel.com \
--cc=isimatu.yasuaki@jp$(echo .)fujitsu.com \
--cc=linux-acpi@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mingo@redhat$(echo .)com \
--cc=nfont@linux$(echo .)vnet.ibm.com \
--cc=rjw@sisk$(echo .)pl \
--cc=srivatsa.bhat@linux$(echo .)vnet.ibm.com \
--cc=tglx@linutronix$(echo .)de \
--cc=x86@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox