From: "Michel Dänzer" <michel@daenzer•net>
To: Benjamin Herrenschmidt <benh@kernel•crashing.org>
Cc: Ben Hutchings <ben@decadent•org.uk>,
linuxppc-dev <linuxppc-dev@lists•ozlabs.org>
Subject: Re: therm_pm72 units, interface
Date: Fri, 27 Sep 2013 17:44:36 +0200 [thread overview]
Message-ID: <1380296676.25686.6.camel@thor.local> (raw)
In-Reply-To: <1375699987.12557.46.camel@pasglop>
On Mon, 2013-08-05 at 20:53 +1000, Benjamin Herrenschmidt wrote:
> On Mon, 2013-08-05 at 12:32 +0200, Michel Dänzer wrote:
> >
> > I did that, sorry should have mentioned that.
> >
> >
> > > > @@ -468,5 +478,3 @@ static struct platform_driver
> > i2c_powermac_driver
> > > > =
> > > > {
> > > > };
> > > >
> > > > module_platform_driver(i2c_powermac_driver);
> > > > -
> > > > -MODULE_ALIAS("platform:i2c-powermac");
> > >
> > > Maybe add the module alias back ? It shouldn't be necessary...
> >
> > Doesn't help.
>
> Hrm, that might require some more involved debugging, figuring out
> what's up with udev etc... that or maybe bisecting.
>
> From what I can tell, we do attach an OF node to the platform device,
> but since the driver has no of match table, we should still fallback to
> the old platform matching style.
>
> I think I see... adding Grant.
Did that work? He's not in Cc on the post I received from the list, but
that might be due to his mailman settings.
> Grant, something broke the auto-loading the of i2c-powermac module. It's
> a platform device, but while it does have a populated "of_node, its
> driver doesn't have an OF match table and relies on the old style
> platform device matching.
>
> That's broken with newer kernels, platform_uevent() calls
> of_device_uevent_modalias() which sees the of_node and thus doesn't
> return -ENOMEM, and we don't create a platform modalias anymore.
>
> Is it legit to add several MODALIAS ? If yes we could add both ... if
> not, we have a problem. Doing real OF matching with that critter is
> tricky at best for various reasons but it needs the of_node because it
> uses it to scan for children.
>
> Any suggestion ?
Any news on this? I recently learned the hard way that loading
i2c-powermac manually via /etc/modules isn't a good workaround, as that
only happens after fsck...
--
Earthling Michel Dänzer | http://www.amd.com
Libre software enthusiast | Mesa and X developer
next prev parent reply other threads:[~2013-09-27 15:53 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-15 17:53 therm_pm72 units, interface Jan Engelhardt
2012-08-15 21:35 ` Benjamin Herrenschmidt
2012-08-16 15:24 ` Jan Engelhardt
2012-08-16 20:51 ` Benjamin Herrenschmidt
2012-08-17 13:51 ` Jan Engelhardt
2012-08-17 20:17 ` Benjamin Herrenschmidt
2012-08-17 14:23 ` Jan Engelhardt
2012-08-15 21:36 ` Benjamin Herrenschmidt
2013-01-17 14:38 ` Jan Engelhardt
2013-01-17 23:38 ` Benjamin Herrenschmidt
2013-07-19 17:43 ` Aaro Koskinen
2013-07-19 23:16 ` Benjamin Herrenschmidt
2013-07-20 20:33 ` Aaro Koskinen
2013-07-20 23:42 ` Benjamin Herrenschmidt
2013-08-02 10:03 ` Michel Dänzer
2013-08-02 12:51 ` Benjamin Herrenschmidt
2013-08-02 14:47 ` Michel Dänzer
2013-08-02 15:58 ` Aaro Koskinen
2013-08-02 16:52 ` Michel Dänzer
2013-08-02 21:02 ` Benjamin Herrenschmidt
2013-08-05 9:13 ` Michel Dänzer
2013-08-05 9:22 ` Benjamin Herrenschmidt
2013-08-05 10:32 ` Michel Dänzer
2013-08-05 10:53 ` Benjamin Herrenschmidt
2013-09-27 15:44 ` Michel Dänzer [this message]
2013-08-02 20:47 ` Benjamin Herrenschmidt
2013-08-02 20:56 ` Ben Hutchings
2013-08-02 21:04 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1380296676.25686.6.camel@thor.local \
--to=michel@daenzer$(echo .)net \
--cc=ben@decadent$(echo .)org.uk \
--cc=benh@kernel$(echo .)crashing.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox