Subject: Re: [PATCH 2/3] powerpc/scom: Replace debugfs interface with cleaner sysfs one

From: Benjamin Herrenschmidt <[email-masked]>
Date: Thu, 10 Oct 2013 21:16:34 +1100

On Thu, 2013-10-10 at 21:06 +1100, Paul Mackerras wrote:
> On Thu, Oct 10, 2013 at 07:18:35PM +1100, Benjamin Herrenschmidt wrote:
> > The debugfs interface was essentially unused, and racy for anything
> > other than manual use by a developer. This provides a more useful
> > sysfs based one which can be used by programs without racing with
> > each other essentially by providing a file to read/write with an
> > offset being the scom address << 8.
> 
> Don't you mean address << 3 (or address * 8)?

Yes, typo in the comment, the code is fine. I was tired :)

Cheers,
Ben.