From: Scott Wood <scottwood@freescale•com>
To: Prabhakar Kushwaha <prabhakar@freescale•com>
Cc: Varun Sethi <Varun.Sethi@freescale•com>,
linuxppc-dev@lists•ozlabs.org,
Poonam Aggrwal <poonam.aggrwal@freescale•com>,
Priyanka Jain <Priyanka.Jain@freescale•com>
Subject: Re: [PATCH 1/2][v8] powerpc/mpc85xx:Add initial device tree support of T104x
Date: Mon, 28 Oct 2013 20:11:25 -0500 [thread overview]
Message-ID: <1383009085.3410.46.camel@snotra.buserror.net> (raw)
In-Reply-To: <5264A161.6030803@freescale.com>
On Mon, 2013-10-21 at 09:07 +0530, Prabhakar Kushwaha wrote:
> Hi Ben,
>
> This patch is present in upstream review list from a long time.
> There are no review comments.
>
> So, I request you to pick this patch-set for powerpc.git repository.
> http://patchwork.ozlabs.org/patch/280207/
> http://patchwork.ozlabs.org/patch/280208/
This revision has only been posted for about 2.5 weeks.
> > + #address-cells = <1>;
> > + #size-cells = <1>;
> > + pll0: pll0@800 {
> > + #clock-cells = <1>;
> > + reg = <0x800 4>;
> > + compatible = "fsl,qoriq-core-pll-2.0";
> > + clocks = <&clockgen>;
> > + clock-output-names = "pll0", "pll0-div2", "pll0-div4";
> > + };
> > + pll1: pll1@820 {
> > + #clock-cells = <1>;
> > + reg = <0x820 4>;
> > + compatible = "fsl,qoriq-core-pll-2.0";
> > + clocks = <&clockgen>;
> > + clock-output-names = "pll1", "pll1-div2", "pll1-div4";
> > + };
> > + mux0: mux0@0 {
> > + #clock-cells = <0>;
> > + reg = <0x0 4>;
> > + compatible = "fsl,core-mux-clock";
> > + clocks = <&pll0 0>, <&pll0 1>, <&pll0 2>,
> > + <&pll1 0>, <&pll1 1>, <&pll1 2>;
> > + clock-names = "pll0_0", "pll0_1", "pll0_2",
> > + "pll1_0", "pll1_1", "pll1_2";
> > + clock-output-names = "cmux0";
> > + };
The clock bindings are still under discussion.
> > +++ b/arch/powerpc/boot/dts/fsl/t104xsi-pre.dtsi
> > @@ -0,0 +1,106 @@
> > +/*
> > + * T1040/T1042 Silicon/SoC Device Tree Source (pre include)
> > + *
> > + * Copyright 2013 Freescale Semiconductor Inc.
> > + *
> > + * Redistribution and use in source and binary forms, with or without
> > + * modification, are permitted provided that the following conditions are met:
> > + * * Redistributions of source code must retain the above copyright
> > + * notice, this list of conditions and the following disclaimer.
> > + * * Redistributions in binary form must reproduce the above copyright
> > + * notice, this list of conditions and the following disclaimer in the
> > + * documentation and/or other materials provided with the distribution.
> > + * * Neither the name of Freescale Semiconductor nor the
> > + * names of its contributors may be used to endorse or promote products
> > + * derived from this software without specific prior written permission.
> > + *
> > + *
> > + * ALTERNATIVELY, this software may be distributed under the terms of the
> > + * GNU General Public License ("GPL") as published by the Free Software
> > + * Foundation, either version 2 of that License or (at your option) any
> > + * later version.
> > + *
> > + * THIS SOFTWARE IS PROVIDED BY Freescale Semiconductor ``AS IS'' AND ANY
> > + * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
> > + * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
> > + * DISCLAIMED. IN NO EVENT SHALL Freescale Semiconductor BE LIABLE FOR ANY
> > + * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
> > + * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
> > + * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
> > + * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
> > + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
> > + * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> > + */
> > +
> > +/dts-v1/;
> > +
> > +/include/ "e5500_power_isa.dtsi"
> > +
> > +/ {
> > + compatible = "fsl,T104x";
No wildcards in compatibles. If your response is that this will get
overwritten anyway, then why have compatible here at all?
> > + crypto = &crypto;
> > +
> > + };
No blank lines before a closing brace.
-Scott
next prev parent reply other threads:[~2013-10-29 1:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-03 3:44 [PATCH 1/2][v8] powerpc/mpc85xx:Add initial device tree support of T104x Prabhakar Kushwaha
2013-10-21 3:37 ` Prabhakar Kushwaha
2013-10-29 1:11 ` Scott Wood [this message]
2013-10-29 3:40 ` Prabhakar Kushwaha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1383009085.3410.46.camel@snotra.buserror.net \
--to=scottwood@freescale$(echo .)com \
--cc=Priyanka.Jain@freescale$(echo .)com \
--cc=Varun.Sethi@freescale$(echo .)com \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=poonam.aggrwal@freescale$(echo .)com \
--cc=prabhakar@freescale$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox