Subject: Re: [PATCH V4 08/10] powerpc, perf: Enable SW filtering in branch stack sampling framework

From: Michael Ellerman <[email-masked]>
Date: Fri, 13 Dec 2013 13:47:42 +1100

On Thu, 2013-12-12 at 14:15 +0530, Anshuman Khandual wrote:
> On 12/10/2013 11:27 AM, Anshuman Khandual wrote:
> > On 12/09/2013 11:51 AM, Michael Ellerman wrote:
> >> This code was already in need of some unindentation, and now it's just
> >> ridiculous.
> >>
> >> To start with at the beginning of this routine we have:
> >>
> >> while (..) {
> >> 	if (!val)
> >> 		break;
> >> 	else {
> >> 		// Bulk of the logic
> >> 		...
> >> 	}
> >> }
> >>
> >> That should almost always become:
> >>
> >> while (..) {
> >> 	if (!val)
> >> 		break;
> >>
> >> 	// Bulk of the logic
> >> 	...
> >> }
> >>
> >>
> >> But in this case that's not enough. Please send a precursor patch which moves
> >> this logic out into a helper function.
> > 
> > Hey Michael,
> > 
> > I believe this patch should be able to take care of this.

...
 
> Does the patch looks okay ? In which case will send it out separately. Do let
> me know. Thank you.

It's OK.

Don't send it out separately, make it the first patch in your series.

cheers