From: Scott Wood <scottwood@freescale•com>
To: Tiejun Chen <tiejun.chen@windriver•com>
Cc: linuxppc-dev@lists•ozlabs.org
Subject: Re: [PATCH] powerpc: hugetlb: replace __get_cpu_var with get_cpu_var
Date: Mon, 20 Jan 2014 16:17:42 -0600 [thread overview]
Message-ID: <1390256262.24905.315.camel@snotra.buserror.net> (raw)
In-Reply-To: <1390207175-2181-1-git-send-email-tiejun.chen@windriver.com>
On Mon, 2014-01-20 at 16:39 +0800, Tiejun Chen wrote:
> if (atomic_read(&tlb->mm->mm_users) < 2 ||
> cpumask_equal(mm_cpumask(tlb->mm),
> cpumask_of(smp_processor_id()))) {
> kmem_cache_free(hugepte_cache, hugepte);
> + put_cpu_var(hugepd_freelist_cur);
> return;
> }
>
Whitespace
> @@ -491,6 +492,7 @@ static void hugepd_free(struct mmu_gather *tlb, void *hugepte)
> call_rcu_sched(&(*batchp)->rcu, hugepd_free_rcu_callback);
> *batchp = NULL;
> }
> + put_cpu_var(hugepd_freelist_cur);
> }
A blank line before "put_cpu_var" would be nice.
-Scott
prev parent reply other threads:[~2014-01-20 22:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-20 8:39 [PATCH] powerpc: hugetlb: replace __get_cpu_var with get_cpu_var Tiejun Chen
2014-01-20 8:39 ` [PATCH] powerpc: 85xx: EDAC PCI: request irq as IRQF_SHARED Tiejun Chen
2014-01-20 18:30 ` Scott Wood
2014-01-20 22:17 ` Scott Wood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1390256262.24905.315.camel@snotra.buserror.net \
--to=scottwood@freescale$(echo .)com \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=tiejun.chen@windriver$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox