From: Scott Wood <scottwood@freescale•com>
To: Prabhakar Kushwaha <prabhakar@freescale•com>
Cc: linuxppc-dev@lists•ozlabs.org
Subject: Re: [PATCH] powerpc/configs: Enbale Freescale IFC controller
Date: Mon, 20 Jan 2014 16:53:10 -0600 [thread overview]
Message-ID: <1390258390.24905.339.camel@snotra.buserror.net> (raw)
In-Reply-To: <52D9F92C.3030003@freescale.com>
On Sat, 2014-01-18 at 09:16 +0530, Prabhakar Kushwaha wrote:
> On 1/18/2014 12:19 AM, Scott Wood wrote:
> > On Fri, 2014-01-17 at 11:02 -0600, Kumar Gala wrote:
> >> On Jan 17, 2014, at 12:09 AM, Prabhakar Kushwaha <prabhakar@freescale•com> wrote:
> >>
> >>> Currently IFC NAND driver is enabled in corenet32smp_defconfig. But IFC
> >>> controller is not enabled
> >>>
> >>> So, Enable IFC controller in corenet32smp_defconfig.
> >>>
> >>> Signed-off-by: Prabhakar Kushwaha <prabhakar@freescale•com>
> >>> ---
> >>> Based upon git://git.kernel.org/pub/scm/linux/kernel/git/scottwood/linux.git
> >>> branch master
> >>>
> >>> arch/powerpc/configs/corenet32_smp_defconfig | 1 +
> >>> 1 file changed, 1 insertion(+)
> >> Shouldn’t the NAND driver get the IFC controller enabled by Kconfig dependancies?
> > Yes (by select, not dependencies).
> >
> > Prabhakar, was there an actual problem you saw before? Did you run
> > savedefconfig after making this change?
> >
> > CONFIG_FSL_IFC isn't even user-selectable (though it probably should be,
> > as how else would it get enabled in the absence of NAND for catching NOR
> > errors?).
> >
>
> Thanks Kumar and Scott for reviewing this patch.
>
> Yes, it should be enabled by Kconfig dependency. as we have
> config FSL_IFC
> bool
> depends on FSL_SOC
>
> The only reason I changed this code because i wanted all powerpc/configs
> to be similar as they have CONFIG_FSL_IFC enabled by default.
>
> arch/powerpc/configs/mpc85xx_smp_defconfig:54:CONFIG_FSL_IFC=y
> arch/powerpc/configs/corenet64_smp_defconfig:29:CONFIG_FSL_IFC=y
> arch/powerpc/configs/mpc85xx_defconfig:51:CONFIG_FSL_IFC=y
>
> So either I should add in corenet32smp_defconfig to make similar to others.
> or
> remove from all.
>
> I chose first option.
Those other defconfigs are wrong, since they differ from what you'd get
after running "make savedefconfig".
-Scott
prev parent reply other threads:[~2014-01-20 22:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-17 6:09 [PATCH] powerpc/configs: Enbale Freescale IFC controller Prabhakar Kushwaha
2014-01-17 17:02 ` Kumar Gala
2014-01-17 18:49 ` Scott Wood
2014-01-18 3:46 ` Prabhakar Kushwaha
2014-01-20 22:53 ` Scott Wood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1390258390.24905.339.camel@snotra.buserror.net \
--to=scottwood@freescale$(echo .)com \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=prabhakar@freescale$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox