From: Scott Wood <scottwood@freescale•com>
To: Jin Zhengxiong-R64188 <Jason.Jin@freescale•com>
Cc: "linux-fbdev@vger•kernel.org" <linux-fbdev@vger•kernel.org>,
Xiubo Li-B47053 <Li.Xiubo@freescale•com>,
"linuxppc-dev@lists•ozlabs.org" <linuxppc-dev@lists•ozlabs.org>,
"timur@tabi•org" <timur@tabi•org>
Subject: Re: [PATCH 2/2] Make the diu driver work without board level initilization
Date: Tue, 1 Apr 2014 16:38:37 -0500 [thread overview]
Message-ID: <1396388317.32034.14.camel@snotra.buserror.net> (raw)
In-Reply-To: <57b9d96d00f64eff90ae6c109c9dec90@BLUPR03MB373.namprd03.prod.outlook.com>
On Tue, 2014-04-01 at 02:28 -0500, Jin Zhengxiong-R64188 wrote:
> > > + if (!diu_ops.set_pixel_clock) {
> > > + data->pixelclk_reg = of_iomap(np, 1);
> > > + if (!data->pixelclk_reg) {
> > > + dev_err(&pdev->dev, "Cannot map pixelclk registers,
> > please \
> > > + provide the diu_ops for pixclk setting
> > instead.\n");
> >
> > The error message should be in one line if possible, or it will hard to
> > grep.
> > If cannot, should split it into two or more lines, like:
> > + dev_err(&pdev->dev, "Cannot map pixelclk registers,\n"
> > + "please provide the diu_ops for pixclk setting
> > instead.\n");
> Thanks, This has been fixed in the update version, please help to review it at:
> http://patchwork.ozlabs.org/patch/335225/
> I forgot to add the V2 information in the subject in the update patch so this may confuse the reviewer, sorry for that.
It is not fixed in that patch (or did you link the wrong version?). You
should never use \ to continue a line in C, other than in macros.
Further, it is not permitted to wrap kernel output strings. This is an
exception to the 80-column rule. Checkpatch should have told you this.
-Scott
next prev parent reply other threads:[~2014-04-01 21:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-27 11:38 [PATCH 2/2] Make the diu driver work without board level initilization Jason Jin
2014-04-01 2:42 ` Dongsheng.Wang
2014-04-01 2:57 ` Li.Xiubo
2014-04-01 7:28 ` Jason.Jin
2014-04-01 21:38 ` Scott Wood [this message]
2014-04-02 0:22 ` Jason.Jin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1396388317.32034.14.camel@snotra.buserror.net \
--to=scottwood@freescale$(echo .)com \
--cc=Jason.Jin@freescale$(echo .)com \
--cc=Li.Xiubo@freescale$(echo .)com \
--cc=linux-fbdev@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=timur@tabi$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox