From: Michael Ellerman <mpe@ellerman•id.au>
To: Michael Neuling <mikey@neuling•org>
Cc: "kvm-ppc@vger•kernel.org" <kvm-ppc@vger•kernel.org>,
Paul Mackerras <paulus@samba•org>,
linuxppc-dev <linuxppc-dev@lists•ozlabs.org>,
Alexander Graf <agraf@suse•de>,
"kvm@vger•kernel.org" <kvm@vger•kernel.org>
Subject: Re: powerpc/pseries: Use new defines when calling h_set_mode
Date: Fri, 30 May 2014 18:56:47 +1000 [thread overview]
Message-ID: <1401440207.29324.10.camel@concordia> (raw)
In-Reply-To: <1401349547.4116.19.camel@ale.ozlabs.ibm.com>
On Thu, 2014-05-29 at 17:45 +1000, Michael Neuling wrote:
> > > +/* Values for 2nd argument to H_SET_MODE */
> > > +#define H_SET_MODE_RESOURCE_SET_CIABR 1
> > > +#define H_SET_MODE_RESOURCE_SET_DAWR 2
> > > +#define H_SET_MODE_RESOURCE_ADDR_TRANS_MODE 3
> > > +#define H_SET_MODE_RESOURCE_LE 4
> >
> > Much better, but I think you want to make use of these in non-kvm code too,
> > no? At least the LE one is definitely already implemented as call :)
>
> powerpc/pseries: Use new defines when calling h_set_mode
>
> Now that we define these in the KVM code, use these defines when we call
> h_set_mode. No functional change.
>
> Signed-off-by: Michael Neuling <mikey@neuling•org>
> --
> This depends on the KVM h_set_mode patches.
>
> diff --git a/arch/powerpc/include/asm/plpar_wrappers.h b/arch/powerpc/include/asm/plpar_wrappers.h
> index 12c32c5..67859ed 100644
> --- a/arch/powerpc/include/asm/plpar_wrappers.h
> +++ b/arch/powerpc/include/asm/plpar_wrappers.h
> @@ -273,7 +273,7 @@ static inline long plpar_set_mode(unsigned long mflags, unsigned long resource,
> static inline long enable_reloc_on_exceptions(void)
> {
> /* mflags = 3: Exceptions at 0xC000000000004000 */
> - return plpar_set_mode(3, 3, 0, 0);
> + return plpar_set_mode(3, H_SET_MODE_RESOURCE_ADDR_TRANS_MODE, 0, 0);
> }
Which header are these coming from, and why aren't we including it? And is it
going to still build with CONFIG_KVM=n?
cheers
next prev parent reply other threads:[~2014-05-30 8:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1401106626-13130-1-git-send-email-paulus@samba.org>
[not found] ` <1401106626-13130-4-git-send-email-paulus@samba.org>
[not found] ` <5385E620.5090703@suse.de>
[not found] ` <1401342462.4116.4.camel@ale.ozlabs.ibm.com>
[not found] ` <1401344549.4116.8.camel@ale.ozlabs.ibm.com>
[not found] ` <BD1CF085-FEBC-4208-AD3F-C55DB002097F@suse.de>
2014-05-29 7:45 ` powerpc/pseries: Use new defines when calling h_set_mode Michael Neuling
2014-05-29 21:27 ` Alexander Graf
2014-05-29 21:52 ` Benjamin Herrenschmidt
2014-05-30 7:44 ` Alexander Graf
2014-05-30 8:56 ` Michael Ellerman [this message]
2014-05-30 9:10 ` Michael Neuling
2014-05-30 9:13 ` Alexander Graf
2014-05-30 9:44 ` Michael Neuling
2014-05-30 9:44 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1401440207.29324.10.camel@concordia \
--to=mpe@ellerman$(echo .)id.au \
--cc=agraf@suse$(echo .)de \
--cc=kvm-ppc@vger$(echo .)kernel.org \
--cc=kvm@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mikey@neuling$(echo .)org \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox