From: Scott Wood <scottwood@freescale•com>
To: Zhao Qiang-B45475 <qiang.zhao@freescale•com>
Cc: "mkl@pengutronix•de" <mkl@pengutronix•de>,
"linuxppc-dev@lists•ozlabs.org" <linuxppc-dev@lists•ozlabs.org>,
"wg@grandegger•com" <wg@grandegger•com>,
"linux-can@vger•kernel.org" <linux-can@vger•kernel.org>
Subject: Re: [PATCH v2 1/2] flexcan: add err_irq handler for flexcan
Date: Tue, 24 Jun 2014 12:34:58 -0500 [thread overview]
Message-ID: <1403631298.26908.1.camel@snotra.buserror.net> (raw)
In-Reply-To: <fc0a7150924249768aee8e4361c654a1@BLUPR03MB341.namprd03.prod.outlook.com>
On Mon, 2014-06-23 at 01:20 -0500, Zhao Qiang-B45475 wrote:
> On Sat, 2014-06-21 at 12:19, Wood Scott wrote:
>
> > -----Original Message-----
> > From: Wood Scott-B07421
> > Sent: Saturday, June 21, 2014 12:19 AM
> > To: Zhao Qiang-B45475
> > Cc: linuxppc-dev@lists•ozlabs.org; linux-can@vger•kernel.org;
> > wg@grandegger•com; mkl@pengutronix•de; Wood Scott-B07421
> > Subject: Re: [PATCH v2 1/2] flexcan: add err_irq handler for flexcan
> >
> > On Fri, 2014-06-20 at 10:01 +0800, Zhao Qiang wrote:
> > > when flexcan is not physically linked, command 'cantest' will trigger
> > > an err_irq, add err_irq handler for it.
> > >
> > > Signed-off-by: Zhao Qiang <B45475@freescale•com>
> > > ---
> > > Changes for v2:
> > > - use a space instead of tab
> > > - use flexcan_poll_state instead of print
> > >
> > > drivers/net/can/flexcan.c | 31 ++++++++++++++++++++++++++++++-
> > > 1 file changed, 30 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/net/can/flexcan.c b/drivers/net/can/flexcan.c
> > > index f425ec2..7432ba4 100644
> > > --- a/drivers/net/can/flexcan.c
> > > +++ b/drivers/net/can/flexcan.c
> > > @@ -208,6 +208,7 @@ struct flexcan_priv {
> > > void __iomem *base;
> > > u32 reg_esr;
> > > u32 reg_ctrl_default;
> > > + unsigned int err_irq;
> >
> > Why unsigned?
> Err_irq is from 0.
So? irqs are plain "int" almost everywhere in the kernel.
-Scott
next prev parent reply other threads:[~2014-06-24 17:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-20 2:01 [PATCH v2 1/2] flexcan: add err_irq handler for flexcan Zhao Qiang
2014-06-20 2:01 ` [PATCH v2 2/2] flexcan: add err interrupt for p1010rdb Zhao Qiang
2014-06-20 8:52 ` Marc Kleine-Budde
2014-06-20 16:16 ` Scott Wood
2014-06-20 16:19 ` [PATCH v2 1/2] flexcan: add err_irq handler for flexcan Scott Wood
2014-06-23 6:20 ` qiang.zhao
2014-06-24 17:34 ` Scott Wood [this message]
2014-06-25 2:04 ` qiang.zhao
2014-06-21 19:38 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1403631298.26908.1.camel@snotra.buserror.net \
--to=scottwood@freescale$(echo .)com \
--cc=linux-can@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mkl@pengutronix$(echo .)de \
--cc=qiang.zhao@freescale$(echo .)com \
--cc=wg@grandegger$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox