From: Scott Wood <scottwood@freescale•com>
To: Caraman Mihai Claudiu-B02008 <mihai.caraman@freescale•com>
Cc: "linuxppc-dev@lists•ozlabs.org" <linuxppc-dev@lists•ozlabs.org>,
Alexander Graf <agraf@suse•de>,
"kvm-ppc@vger•kernel.org" <kvm-ppc@vger•kernel.org>,
"kvm@vger•kernel.org" <kvm@vger•kernel.org>
Subject: Re: [PATCH 1/6 v2] KVM: PPC: Book3E: Use common defines for SPE/FP/AltiVec int numbers
Date: Fri, 25 Jul 2014 19:10:36 -0500 [thread overview]
Message-ID: <1406333436.29414.151.camel@snotra.buserror.net> (raw)
In-Reply-To: <3807e749871d460f90a57ad47ad2654d@BY2PR03MB508.namprd03.prod.outlook.com>
On Thu, 2014-07-24 at 04:16 -0500, Caraman Mihai Claudiu-B02008 wrote:
> Scott, Alex's request to define SPE handlers only for e500v2 implies changes
> in 32-bit FSL kernel to have exclusive configurations for e200/e500v2 and
> e500mc/e5500. We would probably need something like this, what's your take on it?
That is already a compile-time decision.
> diff --git a/arch/powerpc/kernel/head_fsl_booke.S b/arch/powerpc/kernel/head_fsl_booke.S
> index b497188..9d41015 100644
> --- a/arch/powerpc/kernel/head_fsl_booke.S
> +++ b/arch/powerpc/kernel/head_fsl_booke.S
> @@ -613,6 +613,8 @@ END_FTR_SECTION_IFSET(CPU_FTR_EMB_HV)
> mfspr r10, SPRN_SPRG_RSCRATCH0
> b InstructionStorage
>
> +/* Define SPE handlers only for e500v2 and e200 */
> +#ifndef CONFIG_PPC_E500MC
> #ifdef CONFIG_SPE
> /* SPE Unavailable */
> START_EXCEPTION(SPEUnavailable)
> @@ -626,7 +628,9 @@ END_FTR_SECTION_IFSET(CPU_FTR_EMB_HV)
> EXCEPTION(0x2020, SPE_ALTIVEC_UNAVAIL, SPEUnavailable, \
> unknown_exception, EXC_XFER_EE)
> #endif /* CONFIG_SPE */
> +#endif
This is redundant:
config SPE
bool "SPE Support"
depends on E200 || (E500 && !PPC_E500MC)
default y
> diff --git a/arch/powerpc/kernel/cputable.c b/arch/powerpc/kernel/cputable.c
> index c1faade..3ab65c2 100644
> --- a/arch/powerpc/kernel/cputable.c
> +++ b/arch/powerpc/kernel/cputable.c
> @@ -2030,6 +2030,7 @@ static struct cpu_spec __initdata cpu_specs[] = {
> #endif /* CONFIG_PPC32 */
> #ifdef CONFIG_E500
> #ifdef CONFIG_PPC32
> +#ifndef CONFIG_PPC_E500MC
> { /* e500 */
> .pvr_mask = 0xffff0000,
> .pvr_value = 0x80200000,
> @@ -2069,6 +2070,7 @@ static struct cpu_spec __initdata cpu_specs[] = {
> .machine_check = machine_check_e500,
> .platform = "ppc8548",
> },
> +#endif /* !CONFIG_PPC_E500MC */
> { /* e500mc */
> .pvr_mask = 0xffff0000,
> .pvr_value = 0x80230000,
>
This looks a bit strange -- e500v2 gets excluded if PPC_E500MC, but
e500mc gets included in !PPC_E500MC?
-Scott
next prev parent reply other threads:[~2014-07-26 0:10 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-30 15:34 [PATCH 0/6 v2] KVM: PPC: Book3e: AltiVec support Mihai Caraman
2014-06-30 15:34 ` [PATCH 1/6 v2] KVM: PPC: Book3E: Use common defines for SPE/FP/AltiVec int numbers Mihai Caraman
2014-07-03 12:21 ` Alexander Graf
2014-07-03 15:25 ` mihai.caraman
2014-07-03 15:30 ` Alexander Graf
2014-07-03 15:53 ` mihai.caraman
2014-07-03 22:15 ` Scott Wood
2014-07-03 22:31 ` Scott Wood
2014-07-03 22:35 ` Alexander Graf
2014-07-03 23:00 ` Scott Wood
2014-07-03 23:02 ` Alexander Graf
2014-07-03 22:31 ` Alexander Graf
2014-07-21 13:23 ` mihai.caraman
2014-07-24 9:16 ` mihai.caraman
2014-07-26 0:10 ` Scott Wood [this message]
2014-07-28 8:54 ` mihai.caraman
2014-07-28 22:42 ` Scott Wood
2014-06-30 15:34 ` [PATCH 2/6 v2] KVM: PPC: Book3E: Refactor SPE/FP exit handling Mihai Caraman
2014-07-03 12:21 ` Alexander Graf
2014-06-30 15:34 ` [PATCH 3/6 v2] KVM: PPC: Book3E: Increase FPU laziness Mihai Caraman
2014-07-03 12:28 ` Alexander Graf
2014-07-03 15:46 ` mihai.caraman
2014-07-04 7:46 ` Alexander Graf
2014-07-04 7:52 ` Alexander Graf
2014-06-30 15:34 ` [PATCH 4/6 v2] KVM: PPC: Book3E: Add AltiVec support Mihai Caraman
2014-07-03 12:32 ` Alexander Graf
2014-07-03 15:58 ` mihai.caraman
2014-07-03 23:07 ` Scott Wood
2014-06-30 15:34 ` [PATCH 5/6 v2] KVM: PPC: Book3E: Add ONE_REG " Mihai Caraman
2014-07-03 12:33 ` Alexander Graf
2014-07-03 16:11 ` mihai.caraman
2014-07-04 7:54 ` Alexander Graf
2014-06-30 15:34 ` [PATCH 6/6 v2] KVM: PPC: Book3E: Enable e6500 core Mihai Caraman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1406333436.29414.151.camel@snotra.buserror.net \
--to=scottwood@freescale$(echo .)com \
--cc=agraf@suse$(echo .)de \
--cc=kvm-ppc@vger$(echo .)kernel.org \
--cc=kvm@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mihai.caraman@freescale$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox