From: Scott Wood <scottwood@freescale•com>
To: Jain Priyanka-B32167 <Priyanka.Jain@freescale•com>
Cc: "devicetree@vger•kernel.org" <devicetree@vger•kernel.org>,
"linuxppc-dev@lists•ozlabs.org" <linuxppc-dev@lists•ozlabs.org>,
Kushwaha Prabhakar-B32579 <prabhakar@freescale•com>,
Aggrwal Poonam-B10812 <Poonam.Aggrwal@freescale•com>
Subject: Re: [2/2] powerpc/fsl-booke: Add initial T1042RDB_PI board support
Date: Thu, 31 Jul 2014 00:07:40 -0500 [thread overview]
Message-ID: <1406783260.29414.320.camel@snotra.buserror.net> (raw)
In-Reply-To: <946e9d7e260c4d78b3c025c3eaeec0f5@BY1PR0301MB0853.namprd03.prod.outlook.com>
On Wed, 2014-07-30 at 23:37 -0500, Jain Priyanka-B32167 wrote:
>
> -----Original Message-----
> From: Wood Scott-B07421
> Sent: Thursday, July 31, 2014 1:43 AM
> To: Jain Priyanka-B32167
> Cc: devicetree@vger•kernel.org; linuxppc-dev@lists•ozlabs.org; Aggrwal Poonam-B10812; Kushwaha Prabhakar-B32579
> Subject: Re: [2/2] powerpc/fsl-booke: Add initial T1042RDB_PI board support
>
> On Wed, Jul 09, 2014 at 09:54:11AM +0530, Priyanka Jain wrote:
> > diff --git a/arch/powerpc/boot/dts/t104xrdb.dtsi
> > b/arch/powerpc/boot/dts/t104xrdb.dtsi
> > index 9aaefa5..e7e765f 100644
> > --- a/arch/powerpc/boot/dts/t104xrdb.dtsi
> > +++ b/arch/powerpc/boot/dts/t104xrdb.dtsi
> > @@ -57,7 +57,8 @@
> > };
> >
> > cpld@3,0 {
> > - compatible = "fsl,t1040rdb-cpld","fsl,t1042rdb-cpld";
> > + compatible = "fsl,t1040rdb-cpld","fsl,t1042rdb-cpld",
> > + "fsl,t1042rdb_pi-cpld";
> > reg = <3 0 0x300>;
> > };
> > };
>
> What's going on here? This file is used by all three boards. If you need to distinguish one board's CPLD from another's, you'll have to do it somewhere else. If the CPLDs are exactly the same and no distinction needs to be made, then you don't need three compatible strings. Even then, you may wish to specify the exact board as the first compatible string, but again you'll need to patch that in elsewhere so that it actually matches the board
> .
> As the register set of CPLD for all three boards is same, I am thinking of replacing this with t104srdb-cpld
> compatible = "fsl,t104xrdb-cpld","
> Is this OK?
No. Wildcards aren't allowed in compatible strings, because you never
know what other devices might exist in the future that match the
wildcard.
If the CPLD logic is truly 100% identical, just pick one of the three to
be the canonical name.
-Scott
prev parent reply other threads:[~2014-07-31 5:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-09 4:24 [PATCH 2/2] powerpc/fsl-booke: Add initial T1042RDB_PI board support Priyanka Jain
2014-07-30 20:12 ` [2/2] " Scott Wood
2014-07-31 4:37 ` Priyanka Jain
2014-07-31 5:07 ` Scott Wood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1406783260.29414.320.camel@snotra.buserror.net \
--to=scottwood@freescale$(echo .)com \
--cc=Poonam.Aggrwal@freescale$(echo .)com \
--cc=Priyanka.Jain@freescale$(echo .)com \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=prabhakar@freescale$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox