From: Scott Wood <scottwood@freescale•com>
To: Benjamin Herrenschmidt <benh@kernel•crashing.org>
Cc: linuxppc-dev@lists•ozlabs.org
Subject: Re: [PATCH 2/2] powerpc/nohash: Split __early_init_mmu() into boot and secondary
Date: Tue, 5 Aug 2014 19:48:10 -0500 [thread overview]
Message-ID: <1407286090.7427.19.camel@snotra.buserror.net> (raw)
In-Reply-To: <1407213410.19150.65.camel@pasglop>
On Tue, 2014-08-05 at 14:36 +1000, Benjamin Herrenschmidt wrote:
> On Fri, 2014-08-01 at 22:07 -0500, Scott Wood wrote:
>
> >
> > -void __init early_init_mmu(void)
> > -{
> > - __early_init_mmu(1);
> > -}
> > -
> > void early_init_mmu_secondary(void)
> > {
> > - __early_init_mmu(0);
> > + early_init_mmu_allcpus();
> > }
>
> Small nit, it took me 30s too long to figure out what you were doing due
> to the naming above :)
>
> Call the latter early_init_this_mmu() and keep the global one separate
> such that early_init_mmu() does:
>
> early_init_mmu_common();
> early_init_this_mmu();
I'll do s/mmu_allcpus/this_mmu/ but early_init_mmu() needs to do things
both before and after early_init_mmu_common(). Do you want two new
functions (before and after) or is it OK to just rename
early_init_mmu_allcpus() and put a comment before early_init_mmu()
saying it's just for the boot cpu?
-Scott
next prev parent reply other threads:[~2014-08-06 0:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-02 3:07 [PATCH 1/2] powerpc/64e: Add __ref to early_alloc_pgtable() Scott Wood
2014-08-02 3:07 ` [PATCH 2/2] powerpc/nohash: Split __early_init_mmu() into boot and secondary Scott Wood
2014-08-05 4:36 ` Benjamin Herrenschmidt
2014-08-06 0:48 ` Scott Wood [this message]
2014-08-06 4:58 ` Benjamin Herrenschmidt
2014-08-06 20:09 ` Scott Wood
2014-08-06 20:46 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1407286090.7427.19.camel@snotra.buserror.net \
--to=scottwood@freescale$(echo .)com \
--cc=benh@kernel$(echo .)crashing.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox