Subject: Re: [PATCH v2 4/4] vfio_pci: spapr: Enable VFIO if EEH is not supported

From: Benjamin Herrenschmidt <[email-masked]>
Date: Wed, 06 Aug 2014 14:34:44 +1000

On Tue, 2014-08-05 at 21:44 -0600, Alex Williamson wrote:
> >               ret = vfio_spapr_pci_eeh_open(vdev->pdev);
> > -             if (ret) {
> > -                     vfio_pci_disable(vdev);
> > -                     goto error;
> > -             }
> > +             if (ret)
> > +                     pr_warn_once("EEH is not supported\n");
> >       }
> >  
> >       return 0;
> 
> Now the next question, what's the point of vfio_spapr_pci_eeh_open()
> returning a value?  Couldn't it return void now and this warning can
> go into eeh specific code?  Thanks,

In order to call vfio_pci_disable() when that happens ?

Cheers,
Ben.