Subject: Re: [PATCH V2] powerpc/eeh: Fix kernel crash when passing through VF

From: Michael Ellerman <[email-masked]>
Date: Fri, 12 Sep 2014 13:55:23 +1000

On Thu, 2014-09-11 at 11:42 +0800, Wei Yang wrote:
> diff --git a/arch/powerpc/kernel/eeh.c b/arch/powerpc/kernel/eeh.c
> index 4a45ba8..403445e 100644
> --- a/arch/powerpc/kernel/eeh.c
> +++ b/arch/powerpc/kernel/eeh.c
> @@ -625,7 +625,7 @@ int eeh_pci_enable(struct eeh_pe *pe, int function)
>  int pcibios_set_pcie_reset_state(struct pci_dev *dev, enum pcie_reset_state state)
>  {
>  	struct eeh_dev *edev = pci_dev_to_eeh_dev(dev);
> -	struct eeh_pe *pe = edev->pe;
> +	struct eeh_pe *pe = edev ? edev->pe : NULL;
>  
>  	if (!pe) {
>  		pr_err("%s: No PE found on PCI device %s\n",

We seem to do this or something similar in a few places. Is it worth having a
pci_dev_to_eeh_pe() inline?

cheers