public inbox for linuxppc-dev@ozlabs.org 
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel•crashing.org>
To: Michael Ellerman <mpe@ellerman•id.au>
Cc: linuxppc-dev@lists•ozlabs.org,
	Seth Jennings <sjennings@variantweb•net>,
	Dan Streetman <ddstreet@ieee•org>,
	Robert Jennings <rcj4747@gmail•com>
Subject: Re: [PATCH] drivers/crypto/nx: prevent oops on module exit
Date: Fri, 17 Oct 2014 09:52:29 +1100	[thread overview]
Message-ID: <1413499949.4567.3.camel@pasglop> (raw)
In-Reply-To: <1413499435.28062.2.camel@concordia>

On Fri, 2014-10-17 at 09:43 +1100, Michael Ellerman wrote:
> On Thu, 2014-10-16 at 15:30 -0400, Dan Streetman wrote:
> > Check old_devdata->dev in nx-842 driver before accessing it, as
> > on systems without any nx-842 hardware, the ->dev will never be
> > set.  Currently, the module will cause an oops during unload
> > since old_devdata->dev is null.
> 
> Hi Dan,
> 
> Patch looks reasonable. But I can't merge it, at least not without an ACK:
> 
> $ ./scripts/get_maintainer.pl -f drivers/crypto/nx/
> Nathan Fontenot <nfont@linux•vnet.ibm.com> (supporter:IBM Power 842 com...)
> Marcelo Henrique Cerri <mhcerri@linux•vnet.ibm.com> (supporter:IBM Power in-Nest...)
> Fionnuala Gunter <fin@linux•vnet.ibm.com> (supporter:IBM Power in-Nest...)
> Herbert Xu <herbert@gondor•apana.org.au> (maintainer:CRYPTO API)
> "David S. Miller" <davem@davemloft•net> (maintainer:CRYPTO API)
> linux-crypto@vger•kernel.org (open list:IBM Power in-Nest...)
> linux-kernel@vger•kernel.org (open list)
> 
> 
> If any of the above is out of date please send me a patch for MAINTAINERS.

I think Dan now owns that driver, Dan, please confirm.

Cheers,
Ben.

  reply	other threads:[~2014-10-16 22:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-16 19:30 [PATCH] drivers/crypto/nx: prevent oops on module exit Dan Streetman
2014-10-16 22:43 ` Michael Ellerman
2014-10-16 22:52   ` Benjamin Herrenschmidt [this message]
2014-10-17  7:59     ` Seth Jennings
2014-10-17  8:02       ` Seth Jennings
2014-10-17 22:05     ` Dan Streetman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1413499949.4567.3.camel@pasglop \
    --to=benh@kernel$(echo .)crashing.org \
    --cc=ddstreet@ieee$(echo .)org \
    --cc=linuxppc-dev@lists$(echo .)ozlabs.org \
    --cc=mpe@ellerman$(echo .)id.au \
    --cc=rcj4747@gmail$(echo .)com \
    --cc=sjennings@variantweb$(echo .)net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox