* [PATCH] drivers/crypto/nx: prevent oops on module exit
@ 2014-10-16 19:30 Dan Streetman
2014-10-16 22:43 ` Michael Ellerman
0 siblings, 1 reply; 6+ messages in thread
From: Dan Streetman @ 2014-10-16 19:30 UTC (permalink / raw)
To: benh, Seth Jennings, Robert Jennings; +Cc: linuxppc-dev, Dan Streetman
Check old_devdata->dev in nx-842 driver before accessing it, as
on systems without any nx-842 hardware, the ->dev will never be
set. Currently, the module will cause an oops during unload
since old_devdata->dev is null.
Signed-off-by: Dan Streetman <ddstreet@ieee•org>
---
Also Seth and Rob, you guys should change your emails in this
driver, your IBM emails are still listed.
drivers/crypto/nx/nx-842.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/nx/nx-842.c b/drivers/crypto/nx/nx-842.c
index 061407d..809a220 100644
--- a/drivers/crypto/nx/nx-842.c
+++ b/drivers/crypto/nx/nx-842.c
@@ -1269,7 +1269,7 @@ static void __exit nx842_exit(void)
RCU_INIT_POINTER(devdata, NULL);
spin_unlock_irqrestore(&devdata_mutex, flags);
synchronize_rcu();
- if (old_devdata)
+ if (old_devdata && old_devdata->dev)
dev_set_drvdata(old_devdata->dev, NULL);
kfree(old_devdata);
vio_unregister_driver(&nx842_driver);
--
1.8.3.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] drivers/crypto/nx: prevent oops on module exit
2014-10-16 19:30 [PATCH] drivers/crypto/nx: prevent oops on module exit Dan Streetman
@ 2014-10-16 22:43 ` Michael Ellerman
2014-10-16 22:52 ` Benjamin Herrenschmidt
0 siblings, 1 reply; 6+ messages in thread
From: Michael Ellerman @ 2014-10-16 22:43 UTC (permalink / raw)
To: Dan Streetman; +Cc: linuxppc-dev, Seth Jennings, Robert Jennings
On Thu, 2014-10-16 at 15:30 -0400, Dan Streetman wrote:
> Check old_devdata->dev in nx-842 driver before accessing it, as
> on systems without any nx-842 hardware, the ->dev will never be
> set. Currently, the module will cause an oops during unload
> since old_devdata->dev is null.
Hi Dan,
Patch looks reasonable. But I can't merge it, at least not without an ACK:
$ ./scripts/get_maintainer.pl -f drivers/crypto/nx/
Nathan Fontenot <nfont@linux•vnet.ibm.com> (supporter:IBM Power 842 com...)
Marcelo Henrique Cerri <mhcerri@linux•vnet.ibm.com> (supporter:IBM Power in-Nest...)
Fionnuala Gunter <fin@linux•vnet.ibm.com> (supporter:IBM Power in-Nest...)
Herbert Xu <herbert@gondor•apana.org.au> (maintainer:CRYPTO API)
"David S. Miller" <davem@davemloft•net> (maintainer:CRYPTO API)
linux-crypto@vger•kernel.org (open list:IBM Power in-Nest...)
linux-kernel@vger•kernel.org (open list)
If any of the above is out of date please send me a patch for MAINTAINERS.
cheers
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drivers/crypto/nx: prevent oops on module exit
2014-10-16 22:43 ` Michael Ellerman
@ 2014-10-16 22:52 ` Benjamin Herrenschmidt
2014-10-17 7:59 ` Seth Jennings
2014-10-17 22:05 ` Dan Streetman
0 siblings, 2 replies; 6+ messages in thread
From: Benjamin Herrenschmidt @ 2014-10-16 22:52 UTC (permalink / raw)
To: Michael Ellerman
Cc: linuxppc-dev, Seth Jennings, Dan Streetman, Robert Jennings
On Fri, 2014-10-17 at 09:43 +1100, Michael Ellerman wrote:
> On Thu, 2014-10-16 at 15:30 -0400, Dan Streetman wrote:
> > Check old_devdata->dev in nx-842 driver before accessing it, as
> > on systems without any nx-842 hardware, the ->dev will never be
> > set. Currently, the module will cause an oops during unload
> > since old_devdata->dev is null.
>
> Hi Dan,
>
> Patch looks reasonable. But I can't merge it, at least not without an ACK:
>
> $ ./scripts/get_maintainer.pl -f drivers/crypto/nx/
> Nathan Fontenot <nfont@linux•vnet.ibm.com> (supporter:IBM Power 842 com...)
> Marcelo Henrique Cerri <mhcerri@linux•vnet.ibm.com> (supporter:IBM Power in-Nest...)
> Fionnuala Gunter <fin@linux•vnet.ibm.com> (supporter:IBM Power in-Nest...)
> Herbert Xu <herbert@gondor•apana.org.au> (maintainer:CRYPTO API)
> "David S. Miller" <davem@davemloft•net> (maintainer:CRYPTO API)
> linux-crypto@vger•kernel.org (open list:IBM Power in-Nest...)
> linux-kernel@vger•kernel.org (open list)
>
>
> If any of the above is out of date please send me a patch for MAINTAINERS.
I think Dan now owns that driver, Dan, please confirm.
Cheers,
Ben.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drivers/crypto/nx: prevent oops on module exit
2014-10-16 22:52 ` Benjamin Herrenschmidt
@ 2014-10-17 7:59 ` Seth Jennings
2014-10-17 8:02 ` Seth Jennings
2014-10-17 22:05 ` Dan Streetman
1 sibling, 1 reply; 6+ messages in thread
From: Seth Jennings @ 2014-10-17 7:59 UTC (permalink / raw)
To: Benjamin Herrenschmidt
Cc: linuxppc-dev, Seth Jennings, Dan Streetman, Robert Jennings
> On Fri, 2014-10-17 at 09:43 +1100, Michael Ellerman wrote:
>> On Thu, 2014-10-16 at 15:30 -0400, Dan Streetman wrote:
>> > Check old_devdata->dev in nx-842 driver before accessing it, as
>> > on systems without any nx-842 hardware, the ->dev will never be
>> > set. Currently, the module will cause an oops during unload
>> > since old_devdata->dev is null.
>>
>> Hi Dan,
>>
>> Patch looks reasonable. But I can't merge it, at least not without an
>> ACK:
>>
>> $ ./scripts/get_maintainer.pl -f drivers/crypto/nx/
>> Nathan Fontenot <nfont@linux•vnet.ibm.com> (supporter:IBM Power 842
>> com...)
>> Marcelo Henrique Cerri <mhcerri@linux•vnet.ibm.com> (supporter:IBM Power
>> in-Nest...)
>> Fionnuala Gunter <fin@linux•vnet.ibm.com> (supporter:IBM Power
>> in-Nest...)
>> Herbert Xu <herbert@gondor•apana.org.au> (maintainer:CRYPTO API)
>> "David S. Miller" <davem@davemloft•net> (maintainer:CRYPTO API)
>> linux-crypto@vger•kernel.org (open list:IBM Power in-Nest...)
>> linux-kernel@vger•kernel.org (open list)
>>
>>
>> If any of the above is out of date please send me a patch for
>> MAINTAINERS.
>
> I think Dan now owns that driver, Dan, please confirm.
I guess I'm not on the maintainer list anymore, as I shouldn't be
since I don't work at IBM anymore.
So... yeah. I was the original co-author of driver so I acked it
but I'm not the maintainer anymore. Which I shouldn't be, since
I don't work at IBM anymore.
Seth
>
> Cheers,
> Ben.
>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drivers/crypto/nx: prevent oops on module exit
2014-10-17 7:59 ` Seth Jennings
@ 2014-10-17 8:02 ` Seth Jennings
0 siblings, 0 replies; 6+ messages in thread
From: Seth Jennings @ 2014-10-17 8:02 UTC (permalink / raw)
To: sjennings; +Cc: Robert Jennings, linuxppc-dev, Dan Streetman
>> On Fri, 2014-10-17 at 09:43 +1100, Michael Ellerman wrote:
>>> On Thu, 2014-10-16 at 15:30 -0400, Dan Streetman wrote:
>>> > Check old_devdata->dev in nx-842 driver before accessing it, as
>>> > on systems without any nx-842 hardware, the ->dev will never be
>>> > set. Currently, the module will cause an oops during unload
>>> > since old_devdata->dev is null.
>>>
>>> Hi Dan,
>>>
>>> Patch looks reasonable. But I can't merge it, at least not without an
>>> ACK:
>>>
>>> $ ./scripts/get_maintainer.pl -f drivers/crypto/nx/
>>> Nathan Fontenot <nfont@linux•vnet.ibm.com> (supporter:IBM Power 842
>>> com...)
>>> Marcelo Henrique Cerri <mhcerri@linux•vnet.ibm.com> (supporter:IBM
>>> Power
>>> in-Nest...)
>>> Fionnuala Gunter <fin@linux•vnet.ibm.com> (supporter:IBM Power
>>> in-Nest...)
>>> Herbert Xu <herbert@gondor•apana.org.au> (maintainer:CRYPTO API)
>>> "David S. Miller" <davem@davemloft•net> (maintainer:CRYPTO API)
>>> linux-crypto@vger•kernel.org (open list:IBM Power in-Nest...)
>>> linux-kernel@vger•kernel.org (open list)
>>>
>>>
>>> If any of the above is out of date please send me a patch for
>>> MAINTAINERS.
>>
>> I think Dan now owns that driver, Dan, please confirm.
>
> I guess I'm not on the maintainer list anymore, as I shouldn't be
> since I don't work at IBM anymore.
Wow, I messed that up. Repeating myself :-/ Sorry for the noise.
Seth
>
> So... yeah. I was the original co-author of driver so I acked it
> but I'm not the maintainer anymore. Which I shouldn't be, since
> I don't work at IBM anymore.
>
> Seth
>
>>
>> Cheers,
>> Ben.
>>
>>
>>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drivers/crypto/nx: prevent oops on module exit
2014-10-16 22:52 ` Benjamin Herrenschmidt
2014-10-17 7:59 ` Seth Jennings
@ 2014-10-17 22:05 ` Dan Streetman
1 sibling, 0 replies; 6+ messages in thread
From: Dan Streetman @ 2014-10-17 22:05 UTC (permalink / raw)
To: Benjamin Herrenschmidt, nfont
Cc: linuxppc-dev, Seth Jennings, Robert Jennings
Yep, I own the driver now, I'll send a maintainers patch.
On Thu, Oct 16, 2014 at 6:52 PM, Benjamin Herrenschmidt
<benh@kernel•crashing.org> wrote:
> On Fri, 2014-10-17 at 09:43 +1100, Michael Ellerman wrote:
>> On Thu, 2014-10-16 at 15:30 -0400, Dan Streetman wrote:
>> > Check old_devdata->dev in nx-842 driver before accessing it, as
>> > on systems without any nx-842 hardware, the ->dev will never be
>> > set. Currently, the module will cause an oops during unload
>> > since old_devdata->dev is null.
>>
>> Hi Dan,
>>
>> Patch looks reasonable. But I can't merge it, at least not without an ACK:
>>
>> $ ./scripts/get_maintainer.pl -f drivers/crypto/nx/
>> Nathan Fontenot <nfont@linux•vnet.ibm.com> (supporter:IBM Power 842 com...)
>> Marcelo Henrique Cerri <mhcerri@linux•vnet.ibm.com> (supporter:IBM Power in-Nest...)
>> Fionnuala Gunter <fin@linux•vnet.ibm.com> (supporter:IBM Power in-Nest...)
>> Herbert Xu <herbert@gondor•apana.org.au> (maintainer:CRYPTO API)
>> "David S. Miller" <davem@davemloft•net> (maintainer:CRYPTO API)
>> linux-crypto@vger•kernel.org (open list:IBM Power in-Nest...)
>> linux-kernel@vger•kernel.org (open list)
>>
>>
>> If any of the above is out of date please send me a patch for MAINTAINERS.
>
> I think Dan now owns that driver, Dan, please confirm.
>
> Cheers,
> Ben.
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-10-17 22:05 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-16 19:30 [PATCH] drivers/crypto/nx: prevent oops on module exit Dan Streetman
2014-10-16 22:43 ` Michael Ellerman
2014-10-16 22:52 ` Benjamin Herrenschmidt
2014-10-17 7:59 ` Seth Jennings
2014-10-17 8:02 ` Seth Jennings
2014-10-17 22:05 ` Dan Streetman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox