From: Scott Wood <scottwood@freescale•com>
To: Emil Medve <Emilian.Medve@Freescale•com>
Cc: Mark Rutland <mark.rutland@arm•com>,
"devicetree@vger•kernel.org" <devicetree@vger•kernel.org>,
Pawel Moll <Pawel.Moll@arm•com>,
"ijc+devicetree@hellion•org.uk" <ijc+devicetree@hellion•org.uk>,
"Geoff.Thorpe@freescale•com" <Geoff.Thorpe@Freescale•com>,
"corbet@lwn•net" <corbet@lwn•net>,
"linux-doc@vger•kernel.org" <linux-doc@vger•kernel.org>,
"linuxppc-dev@ozlabs•org" <linuxppc-dev@ozlabs•org>,
"robh+dt@kernel•org" <robh+dt@kernel•org>,
"galak@codeaurora•org" <galak@codeaurora•org>
Subject: Re: [PATCH 2/4] dt/bindings: Introduce the FSL QorIQ DPAA BMan portal(s)
Date: Tue, 28 Oct 2014 13:09:48 -0500 [thread overview]
Message-ID: <1414519788.23458.85.camel@snotra.buserror.net> (raw)
In-Reply-To: <54480DE6.4090604@Freescale.com>
On Wed, 2014-10-22 at 15:04 -0500, Emil Medve wrote:
> Hello Mark,
>
>
> Thanks for having a look at this
>
> On 10/22/2014 09:29 AM, Mark Rutland wrote:
> > I'd feel rather uncomfortable accepting a
> > binding that we already believe to be insufficient to describe the
> > hardware.
> >
> > What do you expect to change?
>
> Related bindings seem incomplete. As such, the PAMU binding (pamu.txt)
> covers incompletely a dynamic LIODN assignment/programming model. The
> current driver uses a static assignment scheme that the binding needs to
> include. I also suspect that once the driver starts supporting the
> dynamic LIODN assignment/programming we might find some wrinkles
How is this different from any of the other QorIQ bindings that have
been merged without such a disclaimer? The static LIODN model is
already there, even if documentation is missing, and should continue to
be supported even if we eventually implement a dynamic LIODN model.
> >> +
> >> + bman-portals@ff4000000 {
> >> + #address-cells = <1>;
> >> + #size-cells = <1>;
> >> + compatible = "simple-bus";
> >> + ranges = <0 0xf 0xf4000000 0x200000>;
> >> +
> >> + bman-portal@0 {
> >> + compatible = "fsl,bman-portal-1.0.0", "fsl,bman-portal";
> >> + reg = <0x0 0x4000 0x100000 0x1000>;
> >
> > It would be easier to read is each entry had its own set of brackets.
> > Initially this looked to me like a single 64-bit address/size pair.
>
> Something like <>, <>? It doesn't seem widely used but I agree is more
> readable. I can include it in the the next spin
The older PPC device trees haven't used it much but I think it's pretty
common in the newer ARM trees.
-Scott
next prev parent reply other threads:[~2014-10-28 18:10 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-22 14:09 [PATCH 1/4] dt/bindings: Introduce the FSL QorIQ DPAA BMan Emil Medve
2014-10-22 14:09 ` [PATCH 2/4] dt/bindings: Introduce the FSL QorIQ DPAA BMan portal(s) Emil Medve
2014-10-22 14:29 ` Mark Rutland
2014-10-22 20:04 ` Emil Medve
2014-10-23 11:16 ` Mark Rutland
2014-10-23 13:28 ` Geoff Thorpe
2014-10-24 9:26 ` Emil Medve
2014-10-28 18:09 ` Scott Wood [this message]
2014-10-22 14:09 ` [PATCH 3/4] dt/bindings: Introduce the FSL QorIQ DPAA QMan Emil Medve
2014-10-22 14:37 ` Mark Rutland
2014-10-22 20:05 ` Emil Medve
2014-10-23 11:26 ` Mark Rutland
2014-10-23 13:51 ` Geoff Thorpe
2014-10-24 9:53 ` Emil Medve
2014-10-22 14:09 ` [PATCH 4/4] dt/bindings: Introduce the FSL QorIQ DPAA QMan portal(s) Emil Medve
2014-10-28 18:27 ` Scott Wood
2014-10-28 14:36 ` [PATCH 1/4] dt/bindings: Introduce the FSL QorIQ DPAA BMan Kumar Gala
2014-10-28 18:08 ` Scott Wood
[not found] ` <1414519738.23458.84.camel__4795.38602890006$1414521743$gmane$org@snotra.buserror.net>
2014-10-29 21:40 ` Emil Medve
2014-10-29 22:16 ` Scott Wood
[not found] ` <1414620996.23458.141.camel__29590.7804662876$1414621051$gmane$org@snotra.buserror.net>
2014-10-30 4:32 ` Emil Medve
2014-10-30 14:51 ` Scott Wood
[not found] ` <1414680683.23458.148.camel__4514.07629666409$1414680744$gmane$org@snotra.buserror.net>
2014-10-30 16:19 ` Emil Medve
2014-10-30 16:29 ` Scott Wood
[not found] ` <1414686590.23458.151.camel__44619.4786033176$1414686664$gmane$org@snotra.buserror.net>
2014-10-30 16:45 ` Emil Medve
2014-10-30 21:26 ` Scott Wood
2014-10-30 21:30 ` Emil Medve
2014-10-30 15:10 ` Varun Sethi
2014-10-28 18:19 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1414519788.23458.85.camel@snotra.buserror.net \
--to=scottwood@freescale$(echo .)com \
--cc=Emilian.Medve@Freescale$(echo .)com \
--cc=Geoff.Thorpe@Freescale$(echo .)com \
--cc=Pawel.Moll@arm$(echo .)com \
--cc=corbet@lwn$(echo .)net \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=galak@codeaurora$(echo .)org \
--cc=ijc+devicetree@hellion$(echo .)org.uk \
--cc=linux-doc@vger$(echo .)kernel.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=mark.rutland@arm$(echo .)com \
--cc=robh+dt@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox