From: Scott Wood <scottwood@freescale•com>
To: Emil Medve <Emilian.Medve@Freescale•com>
Cc: mark.rutland@arm•com, devicetree@vger•kernel.org,
pawel.moll@arm•com, ijc+devicetree@hellion•org.uk,
Geoff.Thorpe@Freescale•com, corbet@lwn•net,
linux-doc@vger•kernel.org, linuxppc-dev@ozlabs•org,
robh+dt@kernel•org, galak@codeaurora•org
Subject: Re: [PATCH 4/4] dt/bindings: Introduce the FSL QorIQ DPAA QMan portal(s)
Date: Tue, 28 Oct 2014 13:27:57 -0500 [thread overview]
Message-ID: <1414520877.23458.97.camel@snotra.buserror.net> (raw)
In-Reply-To: <1413986972-621-4-git-send-email-Emilian.Medve@Freescale.com>
On Wed, 2014-10-22 at 09:09 -0500, Emil Medve wrote:
> +- fsl,liodn
> + Usage: See pamu.txt
> + Value type: <prop-encoded-array>
> + Definition: PAMU property used for static LIODN assignment
There are two LIODNs on these nodes; you need to specifiy here which is
which. Likewise on the crypto subnode.
> +The currently support sub-nodes are:
> + * fman@0
> + * fman@1
> + * pme@0
> + * crypto@0
s/support/supported/
> +These subnodes should have the following properties:
> +
> +- fsl,liodn
> + Usage: See pamu.txt
> + Value type: <prop-encoded-array>
> + Definition: PAMU property used for static LIODN assignment
> +
> +- fsl,iommu-parent
> + Usage: See pamu.txt
> + Value type: <phandle>
> + Definition: PAMU property used for dynamic LIODN assignment
> +
> +- dev-handle
> + Usage: Required
> + Value type: <phandle>
> + Definition: The phandle to the particular hardware device that this
> + portal is connected to.
> +
> +DPAA QMan Pool Channel Nodes
> +
> +Pool Channels are defined with the following properties.
> +
> +PROPERTIES
> +
> +- compatible
> + Usage: Required
> + Value type: <stringlist>
> + Definition: Must include "fsl,qman-pool-channel"
> + May include "fsl,<SoC>-qman-pool-channel"
> +
> +- fsl,qman-channel-id
> + Usage: Required
> + Value type: <u32>
> + Definition: The hardware index of the channel. This can also be
> + determined by dividing any of the channel's 8 work queue
> + IDs by 8
> +
> +EXAMPLE
> +
> +The example below shows a (P4080) BMan portals container/bus node with two portals
> +
> + qman-portals@ff4200000 {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + compatible = "simple-bus";
> + ranges = <0 0xf 0xf4200000 0x200000>;
> +
> + qman-portal@0 {
> + cell-index = <0>;
> + compatible = "fsl,qman-portal-1.2.0", "fsl,qman-portal";
> + reg = <0 0x4000 0x100000 0x1000>;
> + interrupts = <104 2 0 0>;
> + fsl,liodn = <1 2>;
> + fsl,qman-channel-id = <0>;
> +
> + fman@0 {
> + fsl,liodn = <0x21>;
> + dev-handle = <&fman0>;
> + };
> + fman@1 {
> + fsl,liodn = <0xa1>;
> + dev-handle = <&fman1>;
> + };
> + crypto@0 {
> + fsl,liodn = <0x41 0x66>;
> + dev-handle = <&crypto>;
> + };
Shouldn't have unit address without reg; use fman0/fman1/crypto instead.
-Scott
next prev parent reply other threads:[~2014-10-28 18:43 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-22 14:09 [PATCH 1/4] dt/bindings: Introduce the FSL QorIQ DPAA BMan Emil Medve
2014-10-22 14:09 ` [PATCH 2/4] dt/bindings: Introduce the FSL QorIQ DPAA BMan portal(s) Emil Medve
2014-10-22 14:29 ` Mark Rutland
2014-10-22 20:04 ` Emil Medve
2014-10-23 11:16 ` Mark Rutland
2014-10-23 13:28 ` Geoff Thorpe
2014-10-24 9:26 ` Emil Medve
2014-10-28 18:09 ` Scott Wood
2014-10-22 14:09 ` [PATCH 3/4] dt/bindings: Introduce the FSL QorIQ DPAA QMan Emil Medve
2014-10-22 14:37 ` Mark Rutland
2014-10-22 20:05 ` Emil Medve
2014-10-23 11:26 ` Mark Rutland
2014-10-23 13:51 ` Geoff Thorpe
2014-10-24 9:53 ` Emil Medve
2014-10-22 14:09 ` [PATCH 4/4] dt/bindings: Introduce the FSL QorIQ DPAA QMan portal(s) Emil Medve
2014-10-28 18:27 ` Scott Wood [this message]
2014-10-28 14:36 ` [PATCH 1/4] dt/bindings: Introduce the FSL QorIQ DPAA BMan Kumar Gala
2014-10-28 18:08 ` Scott Wood
[not found] ` <1414519738.23458.84.camel__4795.38602890006$1414521743$gmane$org@snotra.buserror.net>
2014-10-29 21:40 ` Emil Medve
2014-10-29 22:16 ` Scott Wood
[not found] ` <1414620996.23458.141.camel__29590.7804662876$1414621051$gmane$org@snotra.buserror.net>
2014-10-30 4:32 ` Emil Medve
2014-10-30 14:51 ` Scott Wood
[not found] ` <1414680683.23458.148.camel__4514.07629666409$1414680744$gmane$org@snotra.buserror.net>
2014-10-30 16:19 ` Emil Medve
2014-10-30 16:29 ` Scott Wood
[not found] ` <1414686590.23458.151.camel__44619.4786033176$1414686664$gmane$org@snotra.buserror.net>
2014-10-30 16:45 ` Emil Medve
2014-10-30 21:26 ` Scott Wood
2014-10-30 21:30 ` Emil Medve
2014-10-30 15:10 ` Varun Sethi
2014-10-28 18:19 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1414520877.23458.97.camel@snotra.buserror.net \
--to=scottwood@freescale$(echo .)com \
--cc=Emilian.Medve@Freescale$(echo .)com \
--cc=Geoff.Thorpe@Freescale$(echo .)com \
--cc=corbet@lwn$(echo .)net \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=galak@codeaurora$(echo .)org \
--cc=ijc+devicetree@hellion$(echo .)org.uk \
--cc=linux-doc@vger$(echo .)kernel.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=mark.rutland@arm$(echo .)com \
--cc=pawel.moll@arm$(echo .)com \
--cc=robh+dt@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox