From: Scott Wood <scottwood@freescale•com>
To: Xie Shaohui-B21989 <Shaohui.Xie@freescale•com>
Cc: Liberman Igal-B31950 <Igal.Liberman@freescale•com>,
"linuxppc-dev@lists•ozlabs.org" <linuxppc-dev@lists•ozlabs.org>,
Medve Emilian-EMMEDVE1 <Emilian.Medve@freescale•com>,
"devicetree@vger•kernel.org" <devicetree@vger•kernel.org>
Subject: Re: [PATCH] DT: add MDIO node for FMan node
Date: Thu, 13 Nov 2014 02:04:27 -0600 [thread overview]
Message-ID: <1415865867.15957.58.camel@freescale.com> (raw)
In-Reply-To: <489ad06fda99436eb3307d613b1f8293@DM2PR0301MB0864.namprd03.prod.outlook.com>
On Thu, 2014-11-13 at 02:02 -0600, Xie Shaohui-B21989 wrote:
>
>
> Best Regards,
> Shaohui Xie
>
>
> > -----Original Message-----
> > From: Wood Scott-B07421
> > Sent: Thursday, November 13, 2014 3:15 PM
> > To: Xie Shaohui-B21989
> > Cc: Liberman Igal-B31950; linuxppc-dev@lists•ozlabs.org;
> > devicetree@vger•kernel.org; Medve Emilian-EMMEDVE1
> > Subject: Re: [PATCH] DT: add MDIO node for FMan node
> >
> > On Thu, 2014-11-13 at 01:11 -0600, Xie Shaohui-B21989 wrote:
> > > > -----Original Message-----
> > > > From: Wood Scott-B07421
> > > > Sent: Thursday, November 13, 2014 2:17 PM
> > > > To: Xie Shaohui-B21989
> > > > Cc: Liberman Igal-B31950; linuxppc-dev@lists•ozlabs.org;
> > > > devicetree@vger•kernel.org; Medve Emilian-EMMEDVE1
> > > > Subject: Re: [PATCH] DT: add MDIO node for FMan node
> > > >
> > > > On Wed, 2014-11-12 at 07:40 -0600, Xie Shaohui-B21989 wrote:
> > > > > > -----Original Message-----
> > > > > > From: Wood Scott-B07421
> > > > > > Sent: Wednesday, November 12, 2014 1:38 AM
> > > > > > To: Xie Shaohui-B21989
> > > > > > Cc: Liberman Igal-B31950; linuxppc-dev@lists•ozlabs.org;
> > > > > > devicetree@vger•kernel.org; Medve Emilian-EMMEDVE1
> > > > > > Subject: Re: [PATCH] DT: add MDIO node for FMan node
> > > > > >
> > > > > > On Tue, 2014-11-11 at 04:32 -0600, Xie Shaohui-B21989 wrote:
> > > > > > > > -----Original Message-----
> > > > > > > > From: Wood Scott-B07421
> > > > > > > > Sent: Tuesday, November 11, 2014 8:23 AM
> > > > > > > > To: shh.xie@gmail•com
> > > > > > > > Cc: linuxppc-dev@lists•ozlabs.org;
> > > > > > > > devicetree@vger•kernel.org; Medve Emilian-EMMEDVE1; Xie
> > > > > > > > Shaohui-B21989
> > > > > > > > Subject: Re: [PATCH] DT: add MDIO node for FMan node
> > > > > > > >
> > > > > > > > On Tue, 2014-11-04 at 19:56 +0800, shh.xie@gmail•com wrote:
> > > > > > > > > From: Shaohui Xie <Shaohui.Xie@freescale•com>
> > > > > > > > >
> > > > > > > > > This binding is for FMan MDIO, it covers FMan v2 & FMan v3.
> > > > > > > > >
> > > > > > > > > Signed-off-by: Shaohui Xie <Shaohui.Xie@freescale•com>
> > > > > > > > > ---
> > > > > > > > > based on http://patchwork.ozlabs.org/patch/390351/
> > > > > > > > > for 'next' of
> > > > > > > > >
> > git://git.kernel.org/pub/scm/linux/kernel/git/scottwood/linux.
> > > > > > > > > git
> > > > > > > >
> > > > > > > > Are there any other FMan pieces that are missing from the
> > > > > > > > above
> > > > patch?
> > > > > > > [S.H] I'm adding Igal for this comment.
> > > > > > >
> > > > > > > >
> > > > > > > > > +- bus-frequency
> > > > > > > > > + Usage: optional
> > > > > > > > > + Value type: <u32>
> > > > > > > > > + Definition: Default MDIO bus clock speed.
> > > > > > > >
> > > > > > > > Use clocks/clock-names
> > > > > > > [S.H] The MDIO uses Fman clock and divides it to a proper
> > > > > > > value which
> > > > > > is specified by this property.
> > > > > >
> > > > > > Use clocks/clock-names to describe that relationship.
> > > > > >
> > > > >
> > > > > [S.H] The MDIO node is sub-node and embedded in Fman node, the
> > > > > clocks/clock-names is provided by Fman node, should repeat them in
> > > > > MDIO node? For the default MDIO bus clock speed, maybe "clock-
> > ranges"
> > > > > should be used?
> > > >
> > > > It's a different clock. You wouldn't be repeating. If it's derived
> > > > from the FMan clock, then maybe you don't need anything here (does
> > > > the driver know what the divider is, or would that need to be
> > > > specified in the device tree?), but no more clock-frequency/bus-
> > frequency properties.
> > > >
> > > [S.H] The purpose here is to get a specific clock frequency, driver to
> > use it to calculate the divider.
> > > Then the Fman clock can be divided to the frequency.
> >
> > Oh, so this is stating a desired frequency and not something that already
> > exists? What determines this frequency? Is it based on board design, or
> > just on the MDIO standard, etc? I'm wondering if the device tree is the
> > right place for it.
> [S.H] Yes, a desired frequency which is different with MDIO standard.
I'm not sure what you mean by "different with". Do you mean "different
from"? What does the standard say about frequency?
> The Fman clock and the divider determines this frequency.
> Since Fman clock is different on different SoCs, so specify the desired frequency,
> then to get the proper divider.
Why does the fman clock being different mean the mdio clock should be
different?
-Scott
next prev parent reply other threads:[~2014-11-13 8:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-04 11:56 [PATCH] DT: add MDIO node for FMan node shh.xie
2014-11-10 10:19 ` Shaohui Xie
2014-11-11 0:23 ` Scott Wood
2014-11-11 10:32 ` Shaohui Xie
2014-11-11 17:37 ` Scott Wood
2014-11-11 22:27 ` Joakim Tjernlund
2014-11-12 13:40 ` Shaohui Xie
2014-11-13 6:16 ` Scott Wood
2014-11-13 7:11 ` Shaohui Xie
2014-11-13 7:15 ` Scott Wood
2014-11-13 8:02 ` Shaohui Xie
2014-11-13 8:04 ` Scott Wood [this message]
2014-11-13 8:27 ` Shaohui Xie
2014-11-13 8:29 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1415865867.15957.58.camel@freescale.com \
--to=scottwood@freescale$(echo .)com \
--cc=Emilian.Medve@freescale$(echo .)com \
--cc=Igal.Liberman@freescale$(echo .)com \
--cc=Shaohui.Xie@freescale$(echo .)com \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox