From: Scott Wood <scottwood@freescale•com>
To: Emil Medve <Emilian.Medve@Freescale•com>
Cc: devicetree@vger•kernel.org,
Poonam Aggrwal <poonam.aggrwal@Freescale•com>,
Geoff Thorpe <Geoff.Thorpe@Freescale•com>,
linuxppc-dev@ozlabs•org, Chunhe Lan <Chunhe.Lan@Freescale•com>
Subject: Re: [PATCH v2 3/4] powerpc/mpc85xx: Add FSL QorIQ DPAA BMan support to device tree(s)
Date: Mon, 24 Nov 2014 17:45:36 -0600 [thread overview]
Message-ID: <1416872736.15957.158.camel@freescale.com> (raw)
In-Reply-To: <1416827243-16396-4-git-send-email-Emilian.Medve@Freescale.com>
On Mon, 2014-11-24 at 05:07 -0600, Emil Medve wrote:
> From: Kumar Gala <galak@kernel•crashing.org>
>
> Change-Id: If643fa5ba0a903aef8f5056a2c90ebecc995b760
> Signed-off-by: Kumar Gala <galak@kernel•crashing.org>
> Signed-off-by: Geoff Thorpe <Geoff.Thorpe@freescale•com>
> Signed-off-by: Hai-Ying Wang <Haiying.Wang@freescale•com>
> Signed-off-by: Chunhe Lan <Chunhe.Lan@freescale•com>
> Signed-off-by: Poonam Aggrwal <poonam.aggrwal@freescale•com>
> [Emil Medve: Sync with the upstream binding]
> Signed-off-by: Emil Medve <Emilian.Medve@Freescale•com>
> ---
> arch/powerpc/boot/dts/b4qds.dtsi | 20 ++-
> arch/powerpc/boot/dts/fsl/b4860si-post.dtsi | 60 ++++++-
> arch/powerpc/boot/dts/fsl/b4si-post.dtsi | 84 ++++++++-
> arch/powerpc/boot/dts/fsl/p1023si-post.dtsi | 30 +++-
> arch/powerpc/boot/dts/fsl/p2041si-post.dtsi | 6 +-
> arch/powerpc/boot/dts/fsl/p3041si-post.dtsi | 6 +-
> arch/powerpc/boot/dts/fsl/p4080si-post.dtsi | 6 +-
> arch/powerpc/boot/dts/fsl/p5020si-post.dtsi | 6 +-
> arch/powerpc/boot/dts/fsl/p5040si-post.dtsi | 6 +-
> arch/powerpc/boot/dts/fsl/t1040si-post.dtsi | 60 ++++++-
> arch/powerpc/boot/dts/fsl/t2081si-post.dtsi | 100 ++++++++++-
> arch/powerpc/boot/dts/fsl/t4240si-post.dtsi | 260 +++++++++++++++++++++++++++-
> arch/powerpc/boot/dts/kmcoge4.dts | 18 ++
> arch/powerpc/boot/dts/oca4080.dts | 18 ++
> arch/powerpc/boot/dts/p1023rdb.dts | 21 ++-
> arch/powerpc/boot/dts/p2041rdb.dts | 20 ++-
> arch/powerpc/boot/dts/p3041ds.dts | 20 ++-
> arch/powerpc/boot/dts/p4080ds.dts | 20 ++-
> arch/powerpc/boot/dts/p5020ds.dts | 20 ++-
> arch/powerpc/boot/dts/p5040ds.dts | 20 ++-
> arch/powerpc/boot/dts/t104xqds.dtsi | 20 ++-
> arch/powerpc/boot/dts/t104xrdb.dtsi | 18 ++
> arch/powerpc/boot/dts/t208xqds.dtsi | 20 ++-
> arch/powerpc/boot/dts/t208xrdb.dtsi | 18 ++
> arch/powerpc/boot/dts/t4240qds.dts | 20 ++-
> arch/powerpc/boot/dts/t4240rdb.dts | 18 ++
> 26 files changed, 893 insertions(+), 22 deletions(-)
>
> diff --git a/arch/powerpc/boot/dts/b4qds.dtsi b/arch/powerpc/boot/dts/b4qds.dtsi
> index 6188583..3a73103 100644
> --- a/arch/powerpc/boot/dts/b4qds.dtsi
> +++ b/arch/powerpc/boot/dts/b4qds.dtsi
> @@ -1,7 +1,7 @@
> /*
> * B4420DS Device Tree Source
> *
> - * Copyright 2012 Freescale Semiconductor, Inc.
> + * Copyright 2012 - 2014 Freescale Semiconductor, Inc.
> *
> * Redistribution and use in source and binary forms, with or without
> * modification, are permitted provided that the following conditions are met:
> @@ -104,10 +104,28 @@
> device_type = "memory";
> };
>
> + reserved-memory {
> + #address-cells = <2>;
> + #size-cells = <2>;
> + ranges;
> +
> + bman_fbpr: bman-fbpr {
> + compatible = "fsl,bman-fbpr";
> + alloc-ranges = <0 0 0xffff 0xffffffff>;
> + size = <0 0x1000000>;
> + alignment = <0 0x1000000>;
> + no-map;
> + };
Again, I don't think this should have no-map. It's not required by the
hardware, it doesn't perform as advertised on PPC and would be
burdensome to support on e500, we don't currently create a separate
coherence domain for it, and you haven't indicated that there's been any
benchmarks to show that using a separate coherence domain is beneficial.
Is there a reason why these reserved-memory nodes need to be repeated in
each board dts rather than being in a dtsi?
-Scott
next prev parent reply other threads:[~2014-11-24 23:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-24 11:07 [PATCH v2 0/4] powerpc/mpc85xx: Add FSL QorIQ DPAA B/QMan support to device tree(s) Emil Medve
2014-11-24 11:07 ` [PATCH v2 1/4] powerpc/mpc85xx: Create dts components for the FSL QorIQ DPAA BMan Emil Medve
2014-11-24 11:07 ` [PATCH v2 2/4] powerpc/mpc85xx: Create dts components for the FSL QorIQ DPAA QMan Emil Medve
2014-11-24 11:07 ` [PATCH v2 3/4] powerpc/mpc85xx: Add FSL QorIQ DPAA BMan support to device tree(s) Emil Medve
2014-11-24 23:45 ` Scott Wood [this message]
2014-11-24 11:07 ` [PATCH v2 4/4] powerpc/mpc85xx: Add FSL QorIQ DPAA QMan " Emil Medve
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1416872736.15957.158.camel@freescale.com \
--to=scottwood@freescale$(echo .)com \
--cc=Chunhe.Lan@Freescale$(echo .)com \
--cc=Emilian.Medve@Freescale$(echo .)com \
--cc=Geoff.Thorpe@Freescale$(echo .)com \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=poonam.aggrwal@Freescale$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox