From: Michael Ellerman <mpe@ellerman•id.au>
To: Mahesh Jagannath Salgaonkar <mahesh@linux•vnet.ibm.com>
Cc: linuxppc-dev <linuxppc-dev@ozlabs•org>
Subject: Re: powerpc/powernv: Fix the hmi event version check.
Date: Thu, 27 Nov 2014 09:33:46 +1100 [thread overview]
Message-ID: <1417041226.12952.1.camel@concordia> (raw)
In-Reply-To: <5475AAC8.7040105@linux.vnet.ibm.com>
On Wed, 2014-11-26 at 15:56 +0530, Mahesh Jagannath Salgaonkar wrote:
> On 11/26/2014 09:14 AM, Michael Ellerman wrote:
> > On Thu, 2014-20-11 at 04:14:36 UTC, Mahesh Salgaonkar wrote:
> >> From: Mahesh Salgaonkar <mahesh@linux•vnet.ibm.com>
> >>
> >> The current HMI event structure is an ABI and carries a version field to
> >> accommodate future changes without affecting/rearranging current structure
> >> members that are valid for previous versions. The current version check
> >> "if (hmi_evt->version != OpalHMIEvt_V1)" seems to consider that version
> >> will always be V1 which may not be true in future. If we start supporting
> >> HMI event > V1, this check would fail without printing anything on older
> >> kernels. This patch fixes this issue.
> >
> > It's not clear what you mean when you say "this check would fail without
> > printing anything". The check will fail, and it will print something, ie. the
> > error message.
> >
> > What you mean is "the check will fail, and the HMI info will not be printed".
>
> My Bad, Yes. I meant 'HMI info will not be printed'. Do you want me to
> re spin the patch with correction.
No that's fine, I've fixed it up to be:
The current HMI event structure is an ABI and carries a version field to
accommodate future changes without affecting/rearranging current structure
members that are valid for previous versions.
The current version check "if (hmi_evt->version != OpalHMIEvt_V1)"
doesn't accomodate the fact that the version number may change in
future.
If firmware starts returning an HMI event with version > 1, this check
will fail and no HMI information will be printed on older kernels.
This patch fixes this issue.
> > I'll CC this to stable unless you disagree.
>
> Yes. This patch needs to go to stable.
Yep I've added Cc stable to the patch.
cheers
prev parent reply other threads:[~2014-11-26 22:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-20 4:14 [PATCH] powerpc/powernv: Fix the hmi event version check Mahesh J Salgaonkar
2014-11-26 3:44 ` Michael Ellerman
2014-11-26 10:26 ` Mahesh Jagannath Salgaonkar
2014-11-26 22:33 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1417041226.12952.1.camel@concordia \
--to=mpe@ellerman$(echo .)id.au \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=mahesh@linux$(echo .)vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox