From: Scott Wood <scottwood@freescale•com>
To: Alessio Igor Bogani <alessio.bogani@elettra•eu>
Cc: linuxppc-dev@lists•ozlabs.org
Subject: Re: [RFC PATCH v2 1/1] powerpc/85xx: Add support for Emerson/Artesyn MVME2500.
Date: Thu, 4 Dec 2014 14:16:02 -0600 [thread overview]
Message-ID: <1417724162.334.5.camel@freescale.com> (raw)
In-Reply-To: <1417685009-1640-1-git-send-email-alessio.bogani@elettra.eu>
On Thu, 2014-12-04 at 10:23 +0100, Alessio Igor Bogani wrote:
> +/include/ "fsl/pq3-mpic-message-B.dtsi"
The MPIC message include should be done in the SoC file -- it's not
board-specific.
For some reason I don't see this dtsi being included by anything
currently.
> @@ -80,33 +82,21 @@ CONFIG_UEVENT_HELPER_PATH="/sbin/hotplug"
> CONFIG_DEVTMPFS=y
> CONFIG_DEVTMPFS_MOUNT=y
> CONFIG_MTD=y
> -CONFIG_MTD_OF_PARTS=y
> CONFIG_MTD_CMDLINE_PARTS=y
> -CONFIG_MTD_CHAR=y
> -CONFIG_MTD_BLKDEVS=y
> CONFIG_MTD_BLOCK=y
> CONFIG_FTL=y
> CONFIG_MTD_CFI=y
> -CONFIG_MTD_GEN_PROBE=y
> -CONFIG_MTD_MAP_BANK_WIDTH_1=y
> -CONFIG_MTD_MAP_BANK_WIDTH_2=y
> -CONFIG_MTD_MAP_BANK_WIDTH_4=y
> -CONFIG_MTD_CFI_I1=y
> -CONFIG_MTD_CFI_I2=y
Are these removals due to make savedefconfig? Please have a separate
patch that just runs make savedefconfig first, so that we can see what
actual changes are being made.
Otherwise, looks good.
-Scott
next prev parent reply other threads:[~2014-12-04 20:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-04 9:23 [RFC PATCH v2 1/1] powerpc/85xx: Add support for Emerson/Artesyn MVME2500 Alessio Igor Bogani
2014-12-04 20:16 ` Scott Wood [this message]
2014-12-05 8:10 ` Alessio Igor Bogani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1417724162.334.5.camel@freescale.com \
--to=scottwood@freescale$(echo .)com \
--cc=alessio.bogani@elettra$(echo .)eu \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox