From: Benjamin Herrenschmidt <benh@kernel•crashing.org>
To: Scott Wood <scottwood@freescale•com>
Cc: linuxppc-dev@lists•ozlabs.org,
Purcareata Bogdan <b43198@freescale•com>,
linux-kernel@vger•kernel.org, Andreas Mohr <andi@lisas•de>
Subject: Re: [RFC] PPC: MPIC: necessary readback after EOI?
Date: Wed, 07 Jan 2015 15:44:36 +0100 [thread overview]
Message-ID: <1420641876.5830.32.camel@kernel.crashing.org> (raw)
In-Reply-To: <1420481454.4961.16.camel@freescale.com>
On Mon, 2015-01-05 at 12:10 -0600, Scott Wood wrote:
> It would have been nice if a code comment explained why it was doing the
> readback... I don't see any particular need to wait for EOI completion
> here (unlike when masking).
The EOI is what causes the MPIC to drop it's EE output to the CPU, if the
EOI is processed too slowly & asynchronously (posted write + 33Mhz MPIC)
we observe cases of spurrious interrupts. We had some macs basically getting
a spurrious irq for every MPIC interrupts...
Cheers,
Ben.
next prev parent reply other threads:[~2015-01-07 15:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-05 14:14 [RFC] PPC: MPIC: necessary readback after EOI? Purcareata Bogdan
2015-01-05 17:46 ` Andreas Mohr
2015-01-05 18:10 ` Scott Wood
2015-01-05 18:43 ` Andreas Mohr
2015-01-07 2:56 ` Scott Wood
2015-01-07 14:44 ` Benjamin Herrenschmidt [this message]
2015-01-07 17:04 ` Scott Wood
2015-01-08 19:17 ` Benjamin Herrenschmidt
2015-01-07 14:43 ` Benjamin Herrenschmidt
2015-01-07 14:40 ` Benjamin Herrenschmidt
2015-01-08 0:49 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1420641876.5830.32.camel@kernel.crashing.org \
--to=benh@kernel$(echo .)crashing.org \
--cc=andi@lisas$(echo .)de \
--cc=b43198@freescale$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=scottwood@freescale$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox