Subject: Re: [PATCH] powerpc/mpic: Add DT option to skip readback after EOI

From: Scott Wood <[email-masked]>
Date: Wed, 14 Jan 2015 11:58:32 -0600

On Wed, 2015-01-14 at 11:57 +0000, Bogdan Purcareata wrote:
> The readback is necessary in order to handle PCI posted
> writes,

That is unclear.

>  or when the MPIC is handling interrupts in a loop
> (ppc_md.get_irq).

I'm questioning this one as well -- if reading WHOAMI is sufficient to
sync with the EOI, why wouldn't reading INTACK work as well?

>  Newer MPIC versions don't require this readback. Leave the option
> configurable using a device tree entry.
> 
> This saves a MMIO trap per interrupt.
> 
> Signed-off-by: Scott Wood <[email-masked]>
> Signed-off-by: Bogdan Purcareata <[email-masked]>

You should note changes (e.g. with a [] note between signoffs) if it
differs from the original...

-Scott