From: Michael Ellerman <mpe@ellerman•id.au>
To: Hari Bathini <hbathini@linux•vnet.ibm.com>
Cc: linuxppc-dev <linuxppc-dev@ozlabs•org>,
Mahesh J Salgaonkar <mahesh@linux•vnet.ibm.com>
Subject: Re: [PATCH v3 1/3] powerpc/nvram: move generic code for nvram and pstore
Date: Thu, 15 Jan 2015 09:28:33 +1100 [thread overview]
Message-ID: <1421274513.11409.1.camel@ellerman.id.au> (raw)
In-Reply-To: <54B6AFE8.4000104@linux.vnet.ibm.com>
On Wed, 2015-01-14 at 23:35 +0530, Hari Bathini wrote:
> On 01/14/2015 10:01 AM, Michael Ellerman wrote:
>
> > On Wed, 2014-12-24 at 17:28 +0530, Hari Bathini wrote:
> > > With minor checks, we can move most of the code for nvram
> > > under pseries to a common place to be re-used by other
> > > powerpc platforms like powernv. This patch moves such
> > > common code to arch/powerpc/kernel/nvram_64.c file.
> > As I said in my reply to the previous version:
> >
> > ... you need to keep in mind that it is very common for us to build kernels
> > with both POWERNV=y and PSERIES=y.
> >
> > So you need to make sure you're only using CONFIG_PPC_PSERIES to protect things
> > that are optional on pseries. Not things that we *shouldn't* be doing on
> > powernv.
>
> we could as well do away with the PPC_PSERIES flag in a couple of
> places in
> arch/powerpc/kernel/nvram_64.c, but doing that will unnecessarily add
> few extra variables for !PPC_PSERIES case.
Yep. I'm happy for them to be there, I just want you to explain in the
changelog that you've thought about the PSERIES=y POWERNV=y case and why the
code makes sense for that configuration.
> > Please explain in your commit message how you have dealt with that.
>
> Sure. Will update the changelog
Thanks.
> > Also, you broke the build for every config that doesn't have
> > CONFIG_PPC_PSERIES, all 95 of them. This is pasemi_defconfig for example:
>
> My bad! clobbering_unread_rtas_event should have been static inline
> while defining under !PPC_PSERIES
Correct.
Please make sure you test build at least some of the other configurations in
future. I realise it's too time consuming to build all of them, but ideally for
every config symbol you use in your patch you need to build a kernel config
where that symbol =y and =n (and =m if it's tristate).
cheers
next prev parent reply other threads:[~2015-01-14 22:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-24 11:58 [PATCH v3 0/3] powerpc/pstore: Add pstore support for nvram partitions Hari Bathini
2014-12-24 11:58 ` [PATCH v3 1/3] powerpc/nvram: move generic code for nvram and pstore Hari Bathini
2015-01-14 4:31 ` Michael Ellerman
2015-01-14 18:05 ` Hari Bathini
2015-01-14 22:28 ` Michael Ellerman [this message]
2015-01-16 17:52 ` Hari Bathini
2014-12-24 11:58 ` [PATCH v3 2/3] pstore: Add pstore type id for firmware partition Hari Bathini
2015-01-14 4:31 ` Michael Ellerman
2014-12-24 11:58 ` [PATCH v3 3/3] pstore: add pstore support on powernv Hari Bathini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1421274513.11409.1.camel@ellerman.id.au \
--to=mpe@ellerman$(echo .)id.au \
--cc=hbathini@linux$(echo .)vnet.ibm.com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=mahesh@linux$(echo .)vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox