From: Michael Ellerman <michael@ellerman•id.au>
To: Ian Munsie <imunsie@au1•ibm.com>
Cc: Ryan Grimm <grimm@linux•vnet.ibm.com>, mikey <mikey@neuling•org>,
linuxppc-dev <linuxppc-dev@lists•ozlabs.org>
Subject: Re: [PATCH 1/3] CXL: Add image control to sysfs
Date: Thu, 15 Jan 2015 16:07:17 +1100 [thread overview]
Message-ID: <1421298437.11409.4.camel@ellerman.id.au> (raw)
In-Reply-To: <1421295393-sup-926@delenn.ozlabs.ibm.com>
On Thu, 2015-01-15 at 15:41 +1100, Ian Munsie wrote:
> Excerpts from Ryan Grimm's message of 2015-01-15 13:56:39 +1100:
> > Add reset_loads_image and reset_image_select to sysfs.
> >
> > reset_image_select identifies which image will be loaded to the card on the
> > next PERST. Valid entries are: "user" and "factory".
> >
> > reset_loads_image defines functionality on a PERST. Value of 0 means PERST
> > will not cause image load. A power cycle is required to load the image. Value
> > of 1 means PERST will cause image load.
> >
> > sysfs updates the cxl struct in the driver then calls cxl_update_image_control
> > to write the vals in the VSEC.
>
> Let's combine both of these into a single sysfs file, with "none",
> "user" and "factory" options and have the show & read functions handle
> mapping those three options to the two bits in the register.
>
> Of the two names I'd probably go with reset_image_select.
Three words, all can be verbs, two can be nouns, it's not too clear.
Maybe "load_image_on_perst" ?
cheers
next prev parent reply other threads:[~2015-01-15 5:07 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-15 2:56 [PATCH 1/3] CXL: Add image control to sysfs Ryan Grimm
2015-01-15 2:56 ` [PATCH 2/3] CXL: Snoop control Ryan Grimm
2015-01-15 5:16 ` Ian Munsie
2015-01-15 21:46 ` Ryan Grimm
2015-01-15 2:56 ` [PATCH 3/3] CXL: Add reset to sysfs Ryan Grimm
2015-01-15 5:42 ` Ian Munsie
2015-01-15 6:18 ` Ian Munsie
2015-01-15 21:58 ` Ryan Grimm
2015-01-15 5:51 ` Ian Munsie
2015-01-15 4:41 ` [PATCH 1/3] CXL: Add image control " Ian Munsie
2015-01-15 4:46 ` Ian Munsie
2015-01-15 4:54 ` Ian Munsie
2015-01-15 5:07 ` Michael Ellerman [this message]
2015-01-15 5:44 ` Ian Munsie
2015-01-15 21:45 ` Ryan Grimm
-- strict thread matches above, loose matches on Subject: below --
2015-01-15 22:27 Ryan Grimm
2015-01-16 4:15 ` Ian Munsie
2015-01-16 19:29 ` Ryan Grimm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1421298437.11409.4.camel@ellerman.id.au \
--to=michael@ellerman$(echo .)id.au \
--cc=grimm@linux$(echo .)vnet.ibm.com \
--cc=imunsie@au1$(echo .)ibm.com \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mikey@neuling$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox