From: Michael Ellerman <mpe@ellerman•id.au>
To: Tyrel Datwyler <tyreld@linux•vnet.ibm.com>
Cc: linuxppc-dev@lists•ozlabs.org,
Laurent Dufour <ldufour@linux•vnet.ibm.com>,
paulus@samba•org, linux-kernel@vger•kernel.org
Subject: Re: [PATCH] pseries/le: Fix another endiannes issue in RTAS call from xmon
Date: Fri, 16 Jan 2015 09:19:37 +1100 [thread overview]
Message-ID: <1421360377.23332.1.camel@ellerman.id.au> (raw)
In-Reply-To: <54B8188D.1060907@linux.vnet.ibm.com>
On Thu, 2015-01-15 at 11:44 -0800, Tyrel Datwyler wrote:
> On 01/15/2015 09:23 AM, Laurent Dufour wrote:
> > The commit 3b8a3c010969 ("powerpc/pseries: Fix endiannes issue in RTAS
> > call from xmon") was fixing an endianness issue in the call made from
> > xmon to RTAS.
> >
> > However, as Michael Ellerman noticed, this fix was not complete, the
> > token value was not byte swapped. This lead to call an unexpected and
> > most of the time unexisting RTAS function, which is silently ignored
> > by RTAS.
>
> Nit. Not so much that is silently ignored by RTAS as much as
> disable_surveillance silently doesn't check the return status of the
> RTAS call. Maybe a check is warranted and reporting of non-success.
Yeah you're right, I added a printf of the result and got -3, which is also
wrong as far as I can tell, but I didn't have the energy to chase it any
further.
Because this is in xmon we want to be extra careful about what we do, but an
xmon_printf() should be safe. I'll do that as a cleanup after this.
cheers
next prev parent reply other threads:[~2015-01-15 22:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-24 14:07 [PATCH] pseries/le: Fix endiannes issue in RTAS call from xmon Laurent Dufour
2014-11-26 3:31 ` Michael Ellerman
2014-11-26 8:19 ` Laurent Dufour
2015-01-15 4:25 ` [PATCH] " Michael Ellerman
2015-01-15 14:17 ` Laurent Dufour
2015-01-15 17:23 ` [PATCH] pseries/le: Fix another " Laurent Dufour
2015-01-15 19:44 ` Tyrel Datwyler
2015-01-15 22:19 ` Michael Ellerman [this message]
2015-01-15 23:41 ` Tyrel Datwyler
2015-01-16 3:02 ` Michael Ellerman
2015-01-16 10:19 ` Laurent Dufour
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1421360377.23332.1.camel@ellerman.id.au \
--to=mpe@ellerman$(echo .)id.au \
--cc=ldufour@linux$(echo .)vnet.ibm.com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=paulus@samba$(echo .)org \
--cc=tyreld@linux$(echo .)vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox