From: Michael Ellerman <mpe@ellerman•id.au>
To: Dave Jones <davej@codemonkey•org.uk>
Cc: mikey@neuling•org, linux-kernel@vger•kernel.org,
Shuah Khan <shuahkh@osg•samsung.com>,
anton@samba•org, linuxppc-dev@lists•ozlabs.org,
Anshuman Khandual <khandual@linux•vnet.ibm.com>
Subject: Re: [PATCH V2 06/12] selftests, powerpc: Add test for system wide DSCR default
Date: Wed, 21 Jan 2015 17:51:05 +1100 [thread overview]
Message-ID: <1421823065.23864.1.camel@ellerman.id.au> (raw)
In-Reply-To: <20150120214033.GA30240@codemonkey.org.uk>
On Tue, 2015-01-20 at 16:40 -0500, Dave Jones wrote:
> On Wed, Jan 14, 2015 at 10:44:31AM +1100, Michael Ellerman wrote:
>
> > > Also, I would like to see the test results reports using
> > > kselftest.h - it can be separate patch in the interest of
> > > getting tests in.
> >
> > Sorry but kselftest.h doesn't do anything useful for us.
> >
> > We have existing test reporting that uses the subunit protocol.
> >
> > I'm happy to convert that to TAP, or some other well defined output format, but
> > not to something ad-hoc like kselftest.h currently provides.
>
> Something TAP-alike would also help reduce some of the spew from
> tests that are going to fail.
Possibly :)
> eg, running execveat tests on a kernel that doesn't implement that
> syscall currently spews around 20 lines of [FAIL]. Adding something
> to the beginning of the test to set plan() accordingly if it detects
> -ENOSYS could make that output a little cleaner.
Yeah I'm a bit dubious about plan, it often ends up being a pain to calculate
correctly and so it's either missing or wrong.
The execveat test probably just needs an initial test that looks for ENOSYS and
bails entirely. I'll write a patch.
> That other projects (like jenkins, bug trackers etc) could consume
> the output of the test runs would be a nice bonus. I only recently
> started looking at kselftests and was surprised at the amount
> of variance we have in the way of printing 'Ok' '[OK]' 'ok...' etc.
Variance in output is annoying, but putting up too many barriers to entry for
new tests is even less desirable IMHO. Our preference should always be for more
tests in the tree, and we can clean up the output/reporting later.
cheers
next prev parent reply other threads:[~2015-01-21 6:51 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-13 10:22 [PATCH V2 00/12] POWER DSCR fixes, improvements, docs and tests Anshuman Khandual
2015-01-13 10:22 ` [PATCH V2 01/12] powerpc: Fix handling of DSCR related facility unavailable exception Anshuman Khandual
2015-01-13 10:22 ` [PATCH V2 02/12] powerpc, process: Remove the unused extern dscr_default Anshuman Khandual
2015-01-13 10:22 ` [PATCH V2 03/12] powerpc, offset: Change PACA_DSCR to PACA_DSCR_DEFAULT Anshuman Khandual
2015-01-13 10:22 ` [PATCH V2 04/12] powerpc, dscr: Added some in-code documentation Anshuman Khandual
2015-01-13 10:22 ` [PATCH V2 05/12] documentation, powerpc: Add documentation for DSCR support Anshuman Khandual
2015-01-13 10:22 ` [PATCH V2 06/12] selftests, powerpc: Add test for system wide DSCR default Anshuman Khandual
2015-01-13 15:22 ` Shuah Khan
2015-01-13 23:44 ` Michael Ellerman
2015-01-20 21:40 ` Dave Jones
2015-01-21 6:51 ` Michael Ellerman [this message]
2015-03-27 12:01 ` [V2, " Michael Ellerman
2015-04-09 10:31 ` Anshuman Khandual
2015-04-09 12:38 ` Anshuman Khandual
2015-01-13 10:22 ` [PATCH V2 07/12] selftests, powerpc: Add test for explicitly changing DSCR value Anshuman Khandual
2015-01-13 15:23 ` Shuah Khan
2015-01-13 10:22 ` [PATCH V2 08/12] selftests, powerpc: Add test for DSCR SPR numbers Anshuman Khandual
2015-01-13 15:23 ` Shuah Khan
2015-01-13 10:22 ` [PATCH V2 09/12] selftests, powerpc: Add test for DSCR value inheritence across fork Anshuman Khandual
2015-01-13 15:24 ` Shuah Khan
2015-01-13 10:22 ` [PATCH V2 10/12] selftests, powerpc: Add test for DSCR inheritence across fork & exec Anshuman Khandual
2015-01-13 15:24 ` Shuah Khan
2015-01-13 10:22 ` [PATCH V2 11/12] selftests, powerpc: Add test for all DSCR sysfs interfaces Anshuman Khandual
2015-01-13 15:24 ` Shuah Khan
2015-01-13 10:22 ` [PATCH V2 12/12] selftests, powerpc: Add thread based stress test for " Anshuman Khandual
2015-01-13 15:24 ` Shuah Khan
2015-02-04 8:21 ` [PATCH V2 00/12] POWER DSCR fixes, improvements, docs and tests Anshuman Khandual
2015-02-04 8:36 ` Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1421823065.23864.1.camel@ellerman.id.au \
--to=mpe@ellerman$(echo .)id.au \
--cc=anton@samba$(echo .)org \
--cc=davej@codemonkey$(echo .)org.uk \
--cc=khandual@linux$(echo .)vnet.ibm.com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mikey@neuling$(echo .)org \
--cc=shuahkh@osg$(echo .)samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox