From: Michael Ellerman <mpe@ellerman•id.au>
To: "Shreyas B. Prabhu" <shreyas@linux•vnet.ibm.com>
Cc: linuxppc-dev@lists•ozlabs.org, linux-kernel@vger•kernel.org
Subject: Re: [PATCH v2 1/2] powerpc: Add helpers for LPCR PECE1 operations
Date: Fri, 23 Jan 2015 14:06:32 +1100 [thread overview]
Message-ID: <1421982392.24984.9.camel@ellerman.id.au> (raw)
In-Reply-To: <1421654727-31656-1-git-send-email-shreyas@linux.vnet.ibm.com>
On Mon, 2015-01-19 at 13:35 +0530, Shreyas B. Prabhu wrote:
> PECE1 bit in LPCR is used to control whether decrementer can cause exit
> from powersaving states. PECE1 bit is cleared before entering fastsleep
> or deeper powersaving state and it is set on waking up. Since both
> cpuidle and cpu offline operations use these powersaving states, add
> helper functions to be used in both these places.
Thanks.
That isn't really much clearer than the original, so in the end I just merged
your original fix.
I'll think if there's a bigger consolidation we can do that makes it clearer.
cheers
next prev parent reply other threads:[~2015-01-23 3:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-19 8:05 [PATCH v2 1/2] powerpc: Add helpers for LPCR PECE1 operations Shreyas B. Prabhu
2015-01-19 8:05 ` [PATCH v2 2/2] powerpc: powernv: winkle: Restore LPCR with LPCR_PECE1 cleared Shreyas B. Prabhu
2015-01-23 3:06 ` Michael Ellerman [this message]
2015-01-23 3:46 ` [PATCH v2 1/2] powerpc: Add helpers for LPCR PECE1 operations Shreyas B Prabhu
2015-01-23 4:20 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1421982392.24984.9.camel@ellerman.id.au \
--to=mpe@ellerman$(echo .)id.au \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=shreyas@linux$(echo .)vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox