From: Michael Ellerman <mpe@ellerman•id.au>
To: Kim Phillips <kim.phillips@freescale•com>
Cc: Konstantin Khlebnikov <k.khlebnikov@samsung•com>,
Rik van Riel <riel@redhat•com>,
josh@joshtriplett•org, Minchan Kim <minchan@kernel•org>,
LKML <linux-kernel@vger•kernel.org>,
Akinobu Mita <akinobu.mita@gmail•com>, Jens Axboe <axboe@fb•com>,
linux-mm@kvack•org, Al Viro <viro@zeniv•linux.org.uk>,
Johannes Weiner <hannes@cmpxchg•org>,
Sasha Levin <sasha.levin@oracle•com>,
Joonsoo Kim <iamjoonsoo.kim@lge•com>,
linuxppc-dev <linuxppc-dev@lists•ozlabs.org>,
Andrew Morton <akpm@linux-foundation•org>
Subject: Re: [PATCH 2/2] mm: fix undefined reference to `.kernel_map_pages' on PPC builds
Date: Fri, 23 Jan 2015 15:24:51 +1100 [thread overview]
Message-ID: <1421987091.24984.13.camel@ellerman.id.au> (raw)
In-Reply-To: <20150122212017.4b7032d52a6c75c06d5b4728@freescale.com>
On Thu, 2015-01-22 at 21:20 -0600, Kim Phillips wrote:
> On Fri, 23 Jan 2015 08:49:36 +0900
> Akinobu Mita <akinobu.mita@gmail•com> wrote:
>
> > 2015-01-23 5:41 GMT+09:00 Kim Phillips <kim.phillips@freescale•com>:
> > > Thanks. Now I get this:
> > >
> > > LD init/built-in.o
> > > mm/built-in.o: In function `kernel_map_pages':
> > > include/linux/mm.h:2076: undefined reference to `.__kernel_map_pages'
> > > include/linux/mm.h:2076: undefined reference to `.__kernel_map_pages'
> > > include/linux/mm.h:2076: undefined reference to `.__kernel_map_pages'
> > > Makefile:925: recipe for target 'vmlinux' failed
> > > make: *** [vmlinux] Error 1
> > >
> > > but, AFAICT, that's not because this patch is invalid: it's because
> > > __kernel_map_pages() isn't implemented in
> > > arch/powerpc/mm/pgtable_64.c, i.e., for non-PPC_STD_MMU_64 PPC64
> > > machines.
> >
> > Then, in order to use generic __kernel_map_pages() in mm/debug-pagealloc.c,
> > CONFIG_ARCH_SUPPORTS_DEBUG_PAGEALLOC shouldn't be selected in
> > arch/powerpc/Kconfig, when CONFIG_PPC_STD_MMU_64 isn't defined.
>
> Thanks. I'm still build-testing this now:
>
> From 082911ee947246ff962ef21863c45ec467455c40 Mon Sep 17 00:00:00 2001
> From: Kim Phillips <kim.phillips@freescale•com>
> Date: Thu, 22 Jan 2015 20:42:40 -0600
> Subject: [PATCH v2] mm: fix undefined reference to `.__kernel_map_pages' on FSL
> PPC64
>
> arch/powerpc has __kernel_map_pages implementations in mm/pgtable_32.c, and
> mm/hash_utils_64.c, of which the former is built for PPC32, and the latter
> PPC64's without PPC_STD_MMU.
That last part is wrong.
hash_utils_64.c is built for CONFIG_PPC_STD_MMU_64, which is:
config PPC_STD_MMU_64
def_bool y
depends on PPC_STD_MMU && PPC64
The problem is when you have PPC64 && !PPC_STD_MMU.
cheers
next prev parent reply other threads:[~2015-01-23 4:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-20 20:02 [PATCH 2/2] mm: fix undefined reference to `.kernel_map_pages' on PPC builds Kim Phillips
2015-01-20 23:01 ` josh
2015-01-21 0:07 ` Andrew Morton
2015-01-21 12:57 ` Akinobu Mita
2015-01-22 1:45 ` Joonsoo Kim
2015-01-22 20:41 ` Kim Phillips
2015-01-22 23:49 ` Akinobu Mita
2015-01-23 3:20 ` Kim Phillips
2015-01-23 4:24 ` Michael Ellerman [this message]
2015-01-26 19:22 ` [PATCH v3] powerpc/mm: fix undefined reference to `.__kernel_map_pages' on FSL PPC64 Kim Phillips
2015-01-28 1:01 ` Michael Ellerman
2015-01-28 1:33 ` Joonsoo Kim
2015-01-28 2:57 ` Andrew Morton
2015-01-28 3:22 ` Michael Ellerman
2015-01-28 20:14 ` Kim Phillips
2015-01-29 4:05 ` Michael Ellerman
2015-01-26 19:24 ` [PATCH 2/2] mm: fix undefined reference to `.kernel_map_pages' on PPC builds Kim Phillips
2015-01-27 7:56 ` Joonsoo Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1421987091.24984.13.camel@ellerman.id.au \
--to=mpe@ellerman$(echo .)id.au \
--cc=akinobu.mita@gmail$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=axboe@fb$(echo .)com \
--cc=hannes@cmpxchg$(echo .)org \
--cc=iamjoonsoo.kim@lge$(echo .)com \
--cc=josh@joshtriplett$(echo .)org \
--cc=k.khlebnikov@samsung$(echo .)com \
--cc=kim.phillips@freescale$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mm@kvack$(echo .)org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=minchan@kernel$(echo .)org \
--cc=riel@redhat$(echo .)com \
--cc=sasha.levin@oracle$(echo .)com \
--cc=viro@zeniv$(echo .)linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox