public inbox for linuxppc-dev@ozlabs.org 
 help / color / mirror / Atom feed
From: Michael Ellerman <mpe@ellerman•id.au>
To: Greg Kurz <gkurz@linux•vnet.ibm.com>
Cc: linuxppc-dev@lists•ozlabs.org
Subject: Re: [PATCH v2 0/4] VPHN parsing fixes
Date: Tue, 03 Feb 2015 13:47:35 +1100	[thread overview]
Message-ID: <1422931655.4625.6.camel@ellerman.id.au> (raw)
In-Reply-To: <20150129190353.401248ab@bahia.local>

On Thu, 2015-01-29 at 19:03 +0100, Greg Kurz wrote:
> On Wed, 17 Dec 2014 10:40:46 +0100
> Greg Kurz <gkurz@linux•vnet.ibm.com> wrote:
> > Hi,
> > 
> > This series addresses remarks from Ben and Michael (see individual patches).
> > The most notable changes are:
> > - the parsing code being pull out into a separate file in patch 3/4. This
> >   allows to write userland tests like the one below.
> > - a full rewrite of the parsing logic in patch 4/4
> > 
> 
> Ping ?

Sorry, lots of patches needing review.

This looks pretty good at a glance, but did you actually write a userspace test
for it? If so please send it. I'm happy to rework it into something that can go
in selftests.

cheers

  reply	other threads:[~2015-02-03  2:47 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-17  9:40 [PATCH v2 0/4] VPHN parsing fixes Greg Kurz
2014-12-17  9:41 ` [PATCH v2 1/4] powerpc/vphn: clarify the H_HOME_NODE_ASSOCIATIVITY API Greg Kurz
2014-12-17  9:42 ` [PATCH v2 2/4] powerpc/vphn: move endianness fixing to vphn_unpack_associativity() Greg Kurz
2014-12-17  9:42 ` [PATCH v2 3/4] powerpc/vphn: move VPHN parsing logic to a separate file Greg Kurz
2014-12-17  9:43 ` [PATCH v2 4/4] powerpc/vphn: parsing code rewrite Greg Kurz
2015-01-29 18:03 ` [PATCH v2 0/4] VPHN parsing fixes Greg Kurz
2015-02-03  2:47   ` Michael Ellerman [this message]
2015-02-03  7:46     ` Greg Kurz
2015-02-04  0:42       ` Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1422931655.4625.6.camel@ellerman.id.au \
    --to=mpe@ellerman$(echo .)id.au \
    --cc=gkurz@linux$(echo .)vnet.ibm.com \
    --cc=linuxppc-dev@lists$(echo .)ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox