From: Benjamin Herrenschmidt <benh@kernel•crashing.org>
To: Dave Olson <olson@cumulusnetworks•com>
Cc: Paul Mackerras <paulus@samba•org>, linuxppc-dev@lists•ozlabs.org
Subject: Re: [PATCH 1/1] powerpc: fix missing L2 cache size in /sys/devices/system/cpu
Date: Tue, 10 Feb 2015 19:14:00 +1100 [thread overview]
Message-ID: <1423556040.4924.90.camel@kernel.crashing.org> (raw)
In-Reply-To: <20150210080002.GA23291@cumulusnetworks.com>
On Tue, 2015-02-10 at 00:00 -0800, Dave Olson wrote:
>
> OK, now that I understand that's the case, I'll have to go back and
> re-do the patch to handle both cache-size and d-cache-size for the
> L2 cache (using whichever is present).
I notice that you also didn't modify all the other properties, I would
assume you need to also updates in that area ? Maybe you should
duplicate the whole structure and have the code look for both.
> I don't have any power Macs to use for testing, would one of you be
> willing and able to verify the patch on a power Mac?
>
> The patch below fixes my problem, and I don't think it will break
> platforms like the PowerPC Mac that use d-cache-size
next prev parent reply other threads:[~2015-02-10 8:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-09 22:14 [PATCH 1/1] powerpc: fix missing L2 cache size in /sys/devices/system/cpu Dave Olson
2015-02-09 23:33 ` Michael Ellerman
2015-02-09 23:43 ` Dave Olson
2015-02-10 0:12 ` Benjamin Herrenschmidt
2015-02-10 3:30 ` Michael Ellerman
2015-02-10 8:00 ` Dave Olson
2015-02-10 8:14 ` Benjamin Herrenschmidt [this message]
2015-02-10 16:55 ` Dave Olson
2015-02-10 19:45 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1423556040.4924.90.camel@kernel.crashing.org \
--to=benh@kernel$(echo .)crashing.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=olson@cumulusnetworks$(echo .)com \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox