From: Michael Ellerman <mpe@ellerman•id.au>
To: Arseny Solokha <asolokha@kb•kras.ru>
Cc: Scott Wood <scottwood@freescale•com>,
Paul Mackerras <paulus@samba•org>,
linuxppc-dev@lists•ozlabs.org, linux-kernel@vger•kernel.org
Subject: Re: [PATCH 4/4] powerpc/mpic: remove unused functions
Date: Tue, 24 Feb 2015 15:48:15 +1100 [thread overview]
Message-ID: <1424753295.2318.5.camel@ellerman.id.au> (raw)
In-Reply-To: <87a909xkji.fsf@KB00016249.iskra.kb>
On Fri, 2015-02-20 at 11:40 +0700, Arseny Solokha wrote:
> > If I just get a patch saying "removed unused foo()", I have to go and dig and
> > find out:
> > - was it recently added and will be used soon?
> > - is it ancient and never used, if so can we work out why, ie. feature X
> > never landed so this code is no longer needed.
> > - is it old code that *was* used but isn't now because commit ... removed the
> > last user.
> > - is it code that *should* be used, but isn't for some odd reason?
> >
> >
> > So if you can provide that sort of detail for me, that really adds value to the
> > patch. Otherwise the patch is basically just a TODO for me, to go and work out
> > why the code is unused.
>
> Got it. Will resend the whole series one of these days.
Thanks.
cheers
next prev parent reply other threads:[~2015-02-24 4:48 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-16 10:56 [PATCH 0/4] powerpc: trivial unused functions cleanup Arseny Solokha
2015-02-16 10:56 ` [PATCH 1/4] powerpc/boot: drop planetcore_set_serial_speed Arseny Solokha
2015-02-16 10:56 ` [PATCH 2/4] kvm/ppc/mpic: drop unused IRQ_testbit Arseny Solokha
2015-02-16 10:56 ` [PATCH 3/4] powrepc/qe: drop unused ucc_slow_poll_transmitter_now Arseny Solokha
2015-02-16 10:56 ` [PATCH 4/4] powerpc/mpic: remove unused functions Arseny Solokha
2015-02-19 0:58 ` Michael Ellerman
2015-02-19 12:26 ` Arseny Solokha
2015-02-20 3:34 ` Michael Ellerman
2015-02-20 4:40 ` Arseny Solokha
2015-02-24 4:48 ` Michael Ellerman [this message]
2015-02-23 21:31 ` Scott Wood
2015-02-26 2:39 ` Hongtao Jia
2015-02-26 3:27 ` Scott Wood
2015-02-24 9:05 ` [PATCH V2 0/4] powerpc: trivial unused functions cleanup Arseny Solokha
2015-02-24 9:05 ` [PATCH 1/4] powerpc/boot: drop planetcore_set_serial_speed Arseny Solokha
2015-02-24 9:05 ` [PATCH 2/4] kvm/ppc/mpic: drop unused IRQ_testbit Arseny Solokha
2015-02-24 9:05 ` [PATCH 3/4] powrepc/qe: drop unused ucc_slow_poll_transmitter_now Arseny Solokha
2015-02-24 9:05 ` [PATCH 4/4] powerpc/mpic: remove unused functions Arseny Solokha
2015-02-27 2:25 ` Arseny Solokha
2015-03-20 3:56 ` [PATCH v3 0/4] powerpc: trivial unused functions cleanup Arseny Solokha
2015-03-20 3:56 ` [PATCH 1/4] powerpc/boot: drop planetcore_set_serial_speed Arseny Solokha
2015-03-20 3:56 ` [PATCH 2/4] kvm/ppc/mpic: drop unused IRQ_testbit Arseny Solokha
2015-03-20 11:41 ` Alexander Graf
2015-03-21 6:56 ` [PATCH v4 " Arseny Solokha
2015-03-21 14:54 ` Alexander Graf
2015-03-20 3:56 ` [PATCH 3/4] powrepc/qe: drop unused ucc_slow_poll_transmitter_now Arseny Solokha
2015-03-20 3:56 ` [PATCH 4/4] powerpc/mpic: remove unused functions Arseny Solokha
2015-03-20 4:23 ` [PATCH v3 0/4] powerpc: trivial unused functions cleanup Michael Ellerman
2015-03-20 4:55 ` Arseny Solokha
2015-03-20 5:39 ` Michael Ellerman
2015-03-21 6:56 ` Arseny Solokha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1424753295.2318.5.camel@ellerman.id.au \
--to=mpe@ellerman$(echo .)id.au \
--cc=asolokha@kb$(echo .)kras.ru \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=paulus@samba$(echo .)org \
--cc=scottwood@freescale$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox