From: Michael Ellerman <mpe@ellerman•id.au>
To: Alex Dowad <alexinbeijing@gmail•com>
Cc: Michael Neuling <mikey@neuling•org>,
linux-kernel@vger•kernel.org,
Paul Gortmaker <paul.gortmaker@windriver•com>,
Vineeth Vijayan <vvijayan@mvista•com>,
Anton Blanchard <anton@samba•org>,
Paul Mackerras <paulus@samba•org>,
Christoph Lameter <cl@linux•com>,
"open list:LINUX FOR POWERPC..." <linuxppc-dev@lists•ozlabs.org>
Subject: Re: [23/32] powerpc: copy_thread(): rename 'arg' argument to 'kthread_arg'
Date: Wed, 25 Mar 2015 12:35:22 +1100 [thread overview]
Message-ID: <1427247322.29319.3.camel@ellerman.id.au> (raw)
In-Reply-To: <5511BFDF.6070309@gmail.com>
On Tue, 2015-03-24 at 21:49 +0200, Alex Dowad wrote:
> On 20/03/15 01:54, Michael Ellerman wrote:
> > On Thu, 2015-03-19 at 09:22 +0200, Alex Dowad wrote:
> >> On 19/03/15 08:45, Michael Ellerman wrote:
> >>> On Fri, 2015-13-03 at 18:14:46 UTC, Alex Dowad wrote:
> >>>> The 'arg' argument to copy_thread() is only ever used when forking a new
> >>>> kernel thread. Hence, rename it to 'kthread_arg' for clarity (and consistency
> >>>> with do_fork() and other arch-specific implementations of copy_thread()).
> >>>
> >>> I don't understand the bit about consistency with do_fork() ?
> >>>
> >> This series of patches includes one patch which renames the arg for
> >> do_fork(), and others which rename the same arg for each arch-specific
> >> implementation of copy_thread(). So if all of them are accepted and
> >> merged, then all will be consistent. If only some of the patches are
> >> accepted, I will rewrite the commit message so it doesn't mention
> >> "consistency".
> > Ah OK, I only got patch 23, so I missed the context of the whole series.
> >
> > I'll apply this one to the powerpc tree.
>
> Dear M. Ellerman, sorry for not replying promptly. If you would like to
> apply this directly to the powerpc tree, that is fine, but can I edit
> the commit message to remove the mention of 'consistency'? I doubt that
> all 30+ archs will ever merge this change. Thanks, Alex
I merged it last week:
https://git.kernel.org/cgit/linux/kernel/git/mpe/linux.git/commit/?h=next&id=6eca8933d3ff17bff39d5f10a2a22366d8622fa6
And I edited the commit message more or less as you describe.
And feel free to call me Michael or mpe :)
cheers
prev parent reply other threads:[~2015-03-25 1:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1426270496-26362-1-git-send-email-alexinbeijing@gmail.com>
2015-03-13 18:14 ` [PATCH 23/32] powerpc: copy_thread(): rename 'arg' argument to 'kthread_arg' Alex Dowad
2015-03-19 6:45 ` [23/32] " Michael Ellerman
2015-03-19 7:22 ` Alex Dowad
2015-03-19 23:54 ` Michael Ellerman
2015-03-24 19:49 ` Alex Dowad
2015-03-25 1:35 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427247322.29319.3.camel@ellerman.id.au \
--to=mpe@ellerman$(echo .)id.au \
--cc=alexinbeijing@gmail$(echo .)com \
--cc=anton@samba$(echo .)org \
--cc=cl@linux$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mikey@neuling$(echo .)org \
--cc=paul.gortmaker@windriver$(echo .)com \
--cc=paulus@samba$(echo .)org \
--cc=vvijayan@mvista$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox