From: Joe Perches <joe@perches•com>
To: Stefan Agner <stefan@agner•ch>
Cc: linux-ia64@vger•kernel.org, kernel@stlinux•com,
"Nicolas Ferre" <nicolas.ferre@atmel•com>,
"Timur Tabi" <timur@tabi•org>,
"Patrice Chotard" <patrice.chotard@st•com>,
"Pat Gefre" <pfg@sgi•com>,
"Laxman Dewangan" <ldewangan@nvidia•com>,
"Maciej W. Rozycki" <macro@linux-mips•org>,
"Daniel Walker" <dwalker@fifo99•com>,
sparclinux@vger•kernel.org,
"Sonic Zhang" <sonic.zhang@analog•com>,
"Jiri Slaby" <jslaby@suse•cz>,
"Alexandre Courbot" <gnurou@gmail•com>,
"Russell King" <linux@arm•linux.org.uk>,
"Michal Simek" <michal.simek@xilinx•com>,
"Sören Brinkmann" <soren.brinkmann@xilinx•com>,
linux-serial@vger•kernel.org,
"Tobias Klauser" <tklauser@distanz•ch>,
"Stephen Warren" <swarren@wwwdotorg•org>,
linux-arm-msm@vger•kernel.org,
adi-buildroot-devel@lists•sourceforge.net,
"Thadeu Lima de Souza Cascardo" <cascardo@linux•vnet.ibm.com>,
linux-tegra@vger•kernel.org,
"David Brown" <davidb@codeaurora•org>,
linux-arm-kernel@lists•infradead.org,
"Maxime Coquelin" <maxime.coquelin@st•com>,
"Barry Song" <baohua@kernel•org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation•org>,
linux-kernel@vger•kernel.org,
"Tony Prisk" <linux@prisktech•co.nz>,
"Bryan Huntsman" <bryanh@codeaurora•org>,
"Thierry Reding" <thierry.reding@gmail•com>,
"Uwe Kleine-König" <kernel@pengutronix•de>,
"Vineet Gupta" <vgupta@synopsys•com>,
nios2-dev@lists•rocketboards.org,
linuxppc-dev <linuxppc-dev@lists•ozlabs.org>,
"David S. Miller" <davem@davemloft•net>,
"Srinivas Kandagatla" <srinivas.kandagatla@gmail•com>
Subject: Re: [PATCH V2] tty: serial: Add const to struct uart_ops declarations
Date: Sun, 05 Apr 2015 17:16:14 -0700 [thread overview]
Message-ID: <1428279374.2775.78.camel@perches.com> (raw)
In-Reply-To: <d55b1a1240db66ae651cb99cd713694a@agner.ch>
On Mon, 2015-04-06 at 01:09 +0200, Stefan Agner wrote:
> On 2015-04-05 20:24, Joe Perches wrote:
> > Still compiled only x86 and not cross-compiled or tested.
>
> Cross-compiled with multi_v7_defconfig
[]
> > drivers/tty/serial/fsl_lpuart.c | 4 ++--
>
> Tested that driver on actual hardware, looks fine.
> This driver seems to alter the startup function on initialization:
>
> CC drivers/video/of_display_timing.o
> ../drivers/tty/serial/samsung.c: In function 's3c24xx_serial_init_port':
> ../drivers/tty/serial/samsung.c:1702:3: error: assignment of member
> 'startup' in read-only object
> s3c24xx_serial_ops.startup = s3c64xx_serial_startup;
> ^
Thanks Stefan. Then that one can't be const.
> That is the only thing which popped up with multi_v7_defconfig.
I appreciate the testing.
Greg, Jiri, I'll resend with this fixed in a week or so
after waiting for any other comment or sign of brokenness.
next prev parent reply other threads:[~2015-04-06 0:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-04 17:47 [PATCH] tty: serial: Add const to struct uart_ops declarations Joe Perches
2015-04-04 22:04 ` Stefan Agner
2015-04-05 18:24 ` [PATCH V2] " Joe Perches
2015-04-05 22:23 ` Maciej W. Rozycki
2015-04-05 23:09 ` Stefan Agner
2015-04-06 0:16 ` Joe Perches [this message]
2015-04-06 1:36 ` Sören Brinkmann
2015-04-07 7:14 ` Patrice Chotard
2015-04-07 7:49 ` Tobias Klauser
2015-04-07 12:46 ` Vineet Gupta
2015-04-09 9:48 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1428279374.2775.78.camel@perches.com \
--to=joe@perches$(echo .)com \
--cc=adi-buildroot-devel@lists$(echo .)sourceforge.net \
--cc=baohua@kernel$(echo .)org \
--cc=bryanh@codeaurora$(echo .)org \
--cc=cascardo@linux$(echo .)vnet.ibm.com \
--cc=davem@davemloft$(echo .)net \
--cc=davidb@codeaurora$(echo .)org \
--cc=dwalker@fifo99$(echo .)com \
--cc=gnurou@gmail$(echo .)com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=jslaby@suse$(echo .)cz \
--cc=kernel@pengutronix$(echo .)de \
--cc=kernel@stlinux$(echo .)com \
--cc=ldewangan@nvidia$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-arm-msm@vger$(echo .)kernel.org \
--cc=linux-ia64@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-serial@vger$(echo .)kernel.org \
--cc=linux-tegra@vger$(echo .)kernel.org \
--cc=linux@arm$(echo .)linux.org.uk \
--cc=linux@prisktech$(echo .)co.nz \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=macro@linux-mips$(echo .)org \
--cc=maxime.coquelin@st$(echo .)com \
--cc=michal.simek@xilinx$(echo .)com \
--cc=nicolas.ferre@atmel$(echo .)com \
--cc=nios2-dev@lists$(echo .)rocketboards.org \
--cc=patrice.chotard@st$(echo .)com \
--cc=pfg@sgi$(echo .)com \
--cc=sonic.zhang@analog$(echo .)com \
--cc=soren.brinkmann@xilinx$(echo .)com \
--cc=sparclinux@vger$(echo .)kernel.org \
--cc=srinivas.kandagatla@gmail$(echo .)com \
--cc=stefan@agner$(echo .)ch \
--cc=swarren@wwwdotorg$(echo .)org \
--cc=thierry.reding@gmail$(echo .)com \
--cc=timur@tabi$(echo .)org \
--cc=tklauser@distanz$(echo .)ch \
--cc=vgupta@synopsys$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox